Re: [PATCH][RFC] Make entire ACPI submenu dependent on PM.

Re: [PATCH][RFC] Make entire ACPI submenu dependent on PM.

[Len Brown]

This patch is right, and I applied it.

On i386, it did what it should -- made the menus look better.

Testing x86_64 exposed a latent bug, however.
Since CONFIG_X86_64_ACPI_NUMA=y does a select on ACPI,
it is possible to config a kernel with PM=n
and ACPI=y, which violates ACPI's dependency on PM.

Basically, select of something that has dependencies doesn't
enforce those dependencies.

When will somebody re-write Kconfig into something that
humans can use?

-Len

On Sunday 04 March 2007 13:17, Robert P. J. Day wrote:
> 
>   Make the visibility of the entire ACPI submenu dependent on PM.
> 
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> 
> ---
> 
>   given that de-selecting Power Management (PM) de-activates the
> entire contents of the ACPI submenu, it seems pointless to leave the
> top-level menu entry visible.  but this is just a hack and i'll leave
> it to the official maintainers to do it properly. :-)
> 
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 7c49e10..3208ce0 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -7,6 +7,7 @@ menu "ACPI (Advanced Configuration and Power Interface) Support"
>  	depends on !X86_VISWS
>  	depends on !IA64_HP_SIM
>  	depends on IA64 || X86
> +	depends on PM
> 
>  config ACPI
>  	bool "ACPI Support"
>