Re: CONFIG_IBM_BAY

Holger Macht
2007-03-20T16:07:07Z

On Mon 19. Mar - 11:11:09, Kristen Carlson Accardi wrote:
> On Mon, 19 Mar 2007 15:37:46 +0100
> Holger Macht <hmacht@suse.de> wrote:
>
> > Sure. What actually bothers me is that in its current state, the dock
> > station driver signals 'green' on the dock station as soon as the user
> > presses the hardware undock button, but regardlessly of anything else. I
> > think it would be ok to let the ACPI undock event up to userspace because
> > in many situations it knows best when it is save to undock.
>
> I disagree - as I mentioned, not all laptops actually let you (userspace)
> control the undock process because they don't lock. The dock driver
> does notify user space of an undock, before it actually undocks:

Yes, I know that, but userspace won't have enough time to interact with
the user in this case. I just imagine having an external disk connected to
the usb port of the docking station. In the moment the user undocks, his
unsynced or unwritten data is lost because the usb port gets
disconnected. The user needs the knowledge to actually "save remove" the
external disk before he undocks. You are right, this won't help in case
the dock station has no indication when it is "safe" to undock.

>
> /*
> * here we need to generate the undock
> * event prior to actually doing the undock
> * so that the device struct still exists.
> */
> dock_event(ds, event, UNDOCK_EVENT);
> hotplug_dock_devices(ds, ACPI_NOTIFY_EJECT_REQUEST);
> undock(ds);
> eject_dock(ds);
>
>
> We even notify other subsystems of our intent to undock prior to actually
> doing it.