Re: CONFIG_IBM_BAY

Holger Macht
2007-03-19T14:37:47Z

On Mon 19. Mar - 14:04:03, Matthew Garrett wrote:
> On Mon, Mar 19, 2007 at 02:48:22PM +0100, Holger Macht wrote:
>
> > 1. libata integration into the bay driver
>
> It actually makes sense to tie all PATA/SATA devices to their ACPI
> handles where appropriate - there's already code to do that in
> libata-acpi.c, but it would be nicer if it was integrated in the same
> way that PCI devices are.
>
> > 2. The dock station driver has to inform the bay driver that an undock
> > event took place, right?
>
> Yeah.
>
> > But you still have to deal with mounted filesystems, no matter if it a
> > cardbus or a cdrom. Wouldn't we need something like 'save removal'
> > triggered from userspace like you maybe know from 'the other' operating
> > system?
>
> Yes, there's a need for a mechanism to deal with all of this safely, but
> the same is true of any storage device that can be hotplugged (USB,
> firewire, anything in a hotplug bay...)

Sure. What actually bothers me is that in its current state, the dock
station driver signals 'green' on the dock station as soon as the user
presses the hardware undock button, but regardlessly of anything else. I
think it would be ok to let the ACPI undock event up to userspace because
in many situations it knows best when it is save to undock.

Regards,
Holger