Re: Fw: Re: 2.6.21-rc4-mm1 + 4 hotfixes -- BUG: unable to handle kernel paging request at virtual address 6b6b6ceb -- EIP is at module_put+0x7/0x1f

Andrew Morton
2007-03-28T04:27:22Z

On Tue, 27 Mar 2007 21:19:58 -0700 Greg KH <greg@kroah.com> wrote:

> On Wed, Mar 28, 2007 at 11:52:33AM +0800, Shaohua Li wrote:
> > +static void cpuidle_state_sysfs_release(struct kobject *kobj)
> > +{
> > + /* Nothing required to do here, just workaround kobject warning*/
> > +}
>
> NO!!!

heh. This happens rather a lot.

> Do people think that I add warnings to the kernel so that people can
> just work around them by passing empty functions to the driver core?
>
> Sometimes I wonder why I even try...
>
> Please fix this code, it is wrong.
>

Is it documented anywhere? I always forget the reasoning so I have to
cc you each time I see it happening.