* [patch 3/4] cpuidle: unsigned bitfield
@ 2007-03-27 5:38 akpm
2007-03-29 2:56 ` Len Brown
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2007-03-27 5:38 UTC (permalink / raw)
To: lenb; +Cc: linux-acpi, akpm, randy.dunlap, venkatesh.pallipadi
From: Randy Dunlap <randy.dunlap@oracle.com>
A 1-bit bitfield has no room for a sign bit.
drivers/cpuidle/governors/ladder.c:54:16: error: dubious bitfield without explicit `signed' or `unsigned'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/cpuidle/governors/ladder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/cpuidle/governors/ladder.c~cpuidle-unsigned-bitfield drivers/cpuidle/governors/ladder.c
--- a/drivers/cpuidle/governors/ladder.c~cpuidle-unsigned-bitfield
+++ a/drivers/cpuidle/governors/ladder.c
@@ -51,7 +51,7 @@ struct ladder_device_state {
struct ladder_device {
struct ladder_device_state states[CPUIDLE_STATE_MAX];
- int bm_check:1;
+ unsigned int bm_check:1;
unsigned long bm_check_timestamp;
unsigned long bm_activity; /* FIXME: bm activity should be global */
int last_state_idx;
_
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [patch 3/4] cpuidle: unsigned bitfield
2007-03-27 5:38 [patch 3/4] cpuidle: unsigned bitfield akpm
@ 2007-03-29 2:56 ` Len Brown
0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2007-03-29 2:56 UTC (permalink / raw)
To: akpm; +Cc: linux-acpi, randy.dunlap, venkatesh.pallipadi
applied
thanks,
-len
On Tuesday 27 March 2007 01:38, akpm@linux-foundation.org wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> A 1-bit bitfield has no room for a sign bit.
> drivers/cpuidle/governors/ladder.c:54:16: error: dubious bitfield without explicit `signed' or `unsigned'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/cpuidle/governors/ladder.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/cpuidle/governors/ladder.c~cpuidle-unsigned-bitfield drivers/cpuidle/governors/ladder.c
> --- a/drivers/cpuidle/governors/ladder.c~cpuidle-unsigned-bitfield
> +++ a/drivers/cpuidle/governors/ladder.c
> @@ -51,7 +51,7 @@ struct ladder_device_state {
>
> struct ladder_device {
> struct ladder_device_state states[CPUIDLE_STATE_MAX];
> - int bm_check:1;
> + unsigned int bm_check:1;
> unsigned long bm_check_timestamp;
> unsigned long bm_activity; /* FIXME: bm activity should be global */
> int last_state_idx;
> _
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-29 2:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-27 5:38 [patch 3/4] cpuidle: unsigned bitfield akpm
2007-03-29 2:56 ` Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).