From: Andrew Morton <akpm@linux-foundation.org>
To: wally@theblackmoor.net
Cc: linux-kernel@vger.kernel.org,
"Jung-Ik (John) Lee" <jilee@google.com>,
linux-acpi@vger.kernel.org
Subject: Re: PROBLEM: ACPI Thermal Zone for CPU0 does not update after hibernation
Date: Mon, 9 Apr 2007 17:47:00 -0700 [thread overview]
Message-ID: <20070409174700.2e0a14d8.akpm@linux-foundation.org> (raw)
In-Reply-To: <11584.192.146.101.26.1175890435.squirrel@panacea.theblackmoor.net>
On Fri, 6 Apr 2007 16:13:55 -0400 (EDT)
"Walter Francis" <wally@theblackmoor.net> wrote:
> After hibernating, the CPU0 thermal zone never updates. It will stay at 59C
> forever for example.
>
> I've tried making the thermal driver a module and unloading it before
> hibernating and it didn't help, also went back as far as 2.6.19 and saw the
> same behavior there. Currently using 2.6.21-pre6. If I reboot or suspend to
> *RAM*, the problem fixes itself. And CPU1's thermal zone is fine. But CPU0
> if it's (example) 59C, it stays 59C forever. I'm seeing it in gkrellm, but
> it's coming from /proc/acpi/thermal_zone/*/temperature and verified to match
> there.
Yeah, John spotted a bug in there the other day.
Does this fix it?
--- a/drivers/acpi/thermal.c~acpi-thermal-fix-mod_timer-interval
+++ a/drivers/acpi/thermal.c
@@ -758,7 +758,8 @@ static void acpi_thermal_check(void *dat
del_timer(&(tz->timer));
} else {
if (timer_pending(&(tz->timer)))
- mod_timer(&(tz->timer), (HZ * sleep_time) / 1000);
+ mod_timer(&(tz->timer),
+ jiffies + (HZ * sleep_time) / 1000);
else {
tz->timer.data = (unsigned long)tz;
tz->timer.function = acpi_thermal_run;
_
next parent reply other threads:[~2007-04-10 0:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11584.192.146.101.26.1175890435.squirrel@panacea.theblackmoor.net>
2007-04-10 0:47 ` Andrew Morton [this message]
2007-04-10 1:47 ` PROBLEM: ACPI Thermal Zone for CPU0 does not update after hibernation Walter Francis
2007-04-10 1:57 ` Andrew Morton
2007-04-10 2:18 ` Walter Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070409174700.2e0a14d8.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jilee@google.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wally@theblackmoor.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox