public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: David Brownell <david-b@pacbell.net>
Cc: linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org
Subject: Re: [linux-pm] [patch 2.6.21-rc5-git 1/3] new platform_enable_wake() hook; use it in PCI
Date: Mon, 23 Apr 2007 12:51:06 +0000	[thread overview]
Message-ID: <20070423125106.GA4077@ucw.cz> (raw)
In-Reply-To: <200704051248.56703.david-b@pacbell.net>

Hi!

>  static inline int device_suspend(pm_message_t state)
> --- g26.orig/drivers/base/power/main.c	2007-04-04 13:03:33.000000000 -0700
> +++ g26/drivers/base/power/main.c	2007-04-04 13:03:34.000000000 -0700
> @@ -29,6 +29,9 @@ LIST_HEAD(dpm_off_irq);
>  DECLARE_MUTEX(dpm_sem);
>  DECLARE_MUTEX(dpm_list_sem);
>  
> +int (*platform_enable_wakeup)(struct device *dev, int is_on) = NULL;

Static variables do not need zero initializers.

Otherwise it looks ok.
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2007-04-23 12:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-05 19:48 [patch 2.6.21-rc5-git 1/3] new platform_enable_wake() hook; use it in PCI David Brownell
2007-04-23 12:51 ` Pavel Machek [this message]
2007-04-23 14:23   ` [linux-pm] " David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070423125106.GA4077@ucw.cz \
    --to=pavel@ucw.cz \
    --cc=david-b@pacbell.net \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox