* [PATCH] Disable MSI per FADT
@ 2007-04-25 3:05 Shaohua Li
2007-04-25 5:14 ` Len Brown
2007-04-25 15:01 ` Randy Dunlap
0 siblings, 2 replies; 3+ messages in thread
From: Shaohua Li @ 2007-04-25 3:05 UTC (permalink / raw)
To: linux acpi; +Cc: Len Brown, Greg KH, Henrique de Moraes Holschuh
ACPI spec defines the bit and Microsoft uses it. Suppose Linux should
use it too.
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Index: 2.6.21-rc6/drivers/pci/pci-acpi.c
===================================================================
--- 2.6.21-rc6.orig/drivers/pci/pci-acpi.c 2007-04-06 10:36:56.000000000 +0800
+++ 2.6.21-rc6/drivers/pci/pci-acpi.c 2007-04-25 10:58:12.000000000 +0800
@@ -317,6 +317,10 @@ static int __init acpi_pci_init(void)
{
int ret;
+ if (acpi_gbl_FADT.boot_flags & BAF_MSI_NOT_SUPPORTED) {
+ printk(KERN_INFO"ACPI FADT declares the system doesn't support MSI, so disable it\n");
+ pci_no_msi();
+ }
ret = register_acpi_bus_type(&acpi_pci_bus);
if (ret)
return 0;
Index: 2.6.21-rc6/include/acpi/actbl.h
===================================================================
--- 2.6.21-rc6.orig/include/acpi/actbl.h 2007-04-06 10:36:56.000000000 +0800
+++ 2.6.21-rc6/include/acpi/actbl.h 2007-04-25 10:22:28.000000000 +0800
@@ -276,6 +276,7 @@ enum acpi_prefered_pm_profiles {
#define BAF_LEGACY_DEVICES 0x0001
#define BAF_8042_KEYBOARD_CONTROLLER 0x0002
+#define BAF_MSI_NOT_SUPPORTED 0x0008
#define FADT2_REVISION_ID 3
#define FADT2_MINUS_REVISION_ID 2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Disable MSI per FADT
2007-04-25 3:05 [PATCH] Disable MSI per FADT Shaohua Li
@ 2007-04-25 5:14 ` Len Brown
2007-04-25 15:01 ` Randy Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Len Brown @ 2007-04-25 5:14 UTC (permalink / raw)
To: Shaohua Li; +Cc: linux acpi, Greg KH, Henrique de Moraes Holschuh
Applied.
thanks,
-Len
On Tuesday 24 April 2007 23:05, Shaohua Li wrote:
> ACPI spec defines the bit and Microsoft uses it. Suppose Linux should
> use it too.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
>
> Index: 2.6.21-rc6/drivers/pci/pci-acpi.c
> ===================================================================
> --- 2.6.21-rc6.orig/drivers/pci/pci-acpi.c 2007-04-06 10:36:56.000000000 +0800
> +++ 2.6.21-rc6/drivers/pci/pci-acpi.c 2007-04-25 10:58:12.000000000 +0800
> @@ -317,6 +317,10 @@ static int __init acpi_pci_init(void)
> {
> int ret;
>
> + if (acpi_gbl_FADT.boot_flags & BAF_MSI_NOT_SUPPORTED) {
> + printk(KERN_INFO"ACPI FADT declares the system doesn't support MSI, so disable it\n");
> + pci_no_msi();
> + }
> ret = register_acpi_bus_type(&acpi_pci_bus);
> if (ret)
> return 0;
> Index: 2.6.21-rc6/include/acpi/actbl.h
> ===================================================================
> --- 2.6.21-rc6.orig/include/acpi/actbl.h 2007-04-06 10:36:56.000000000 +0800
> +++ 2.6.21-rc6/include/acpi/actbl.h 2007-04-25 10:22:28.000000000 +0800
> @@ -276,6 +276,7 @@ enum acpi_prefered_pm_profiles {
>
> #define BAF_LEGACY_DEVICES 0x0001
> #define BAF_8042_KEYBOARD_CONTROLLER 0x0002
> +#define BAF_MSI_NOT_SUPPORTED 0x0008
>
> #define FADT2_REVISION_ID 3
> #define FADT2_MINUS_REVISION_ID 2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Disable MSI per FADT
2007-04-25 3:05 [PATCH] Disable MSI per FADT Shaohua Li
2007-04-25 5:14 ` Len Brown
@ 2007-04-25 15:01 ` Randy Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2007-04-25 15:01 UTC (permalink / raw)
To: Shaohua Li; +Cc: linux acpi, Len Brown, Greg KH, Henrique de Moraes Holschuh
On Wed, 25 Apr 2007 11:05:12 +0800 Shaohua Li wrote:
> ACPI spec defines the bit and Microsoft uses it. Suppose Linux should
> use it too.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
ack. looks familiar.
http://marc.info/?l=linux-kernel&m=116361622308907&w=2
http://marc.info/?l=linux-kernel&m=116362326505789&w=2
> Index: 2.6.21-rc6/drivers/pci/pci-acpi.c
> ===================================================================
> --- 2.6.21-rc6.orig/drivers/pci/pci-acpi.c 2007-04-06 10:36:56.000000000 +0800
> +++ 2.6.21-rc6/drivers/pci/pci-acpi.c 2007-04-25 10:58:12.000000000 +0800
> @@ -317,6 +317,10 @@ static int __init acpi_pci_init(void)
> {
> int ret;
>
> + if (acpi_gbl_FADT.boot_flags & BAF_MSI_NOT_SUPPORTED) {
> + printk(KERN_INFO"ACPI FADT declares the system doesn't support MSI, so disable it\n");
> + pci_no_msi();
> + }
> ret = register_acpi_bus_type(&acpi_pci_bus);
> if (ret)
> return 0;
> Index: 2.6.21-rc6/include/acpi/actbl.h
> ===================================================================
> --- 2.6.21-rc6.orig/include/acpi/actbl.h 2007-04-06 10:36:56.000000000 +0800
> +++ 2.6.21-rc6/include/acpi/actbl.h 2007-04-25 10:22:28.000000000 +0800
> @@ -276,6 +276,7 @@ enum acpi_prefered_pm_profiles {
>
> #define BAF_LEGACY_DEVICES 0x0001
> #define BAF_8042_KEYBOARD_CONTROLLER 0x0002
> +#define BAF_MSI_NOT_SUPPORTED 0x0008
>
> #define FADT2_REVISION_ID 3
> #define FADT2_MINUS_REVISION_ID 2
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-04-25 14:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-25 3:05 [PATCH] Disable MSI per FADT Shaohua Li
2007-04-25 5:14 ` Len Brown
2007-04-25 15:01 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox