From: Randy Dunlap <randy.dunlap@oracle.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: linux acpi <linux-acpi@vger.kernel.org>,
Len Brown <lenb@kernel.org>, Greg KH <greg@kroah.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Subject: Re: [PATCH] Disable MSI per FADT
Date: Wed, 25 Apr 2007 08:01:10 -0700 [thread overview]
Message-ID: <20070425080110.ab2bbe5f.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1177470312.11073.10.camel@sli10-conroe.sh.intel.com>
On Wed, 25 Apr 2007 11:05:12 +0800 Shaohua Li wrote:
> ACPI spec defines the bit and Microsoft uses it. Suppose Linux should
> use it too.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
ack. looks familiar.
http://marc.info/?l=linux-kernel&m=116361622308907&w=2
http://marc.info/?l=linux-kernel&m=116362326505789&w=2
> Index: 2.6.21-rc6/drivers/pci/pci-acpi.c
> ===================================================================
> --- 2.6.21-rc6.orig/drivers/pci/pci-acpi.c 2007-04-06 10:36:56.000000000 +0800
> +++ 2.6.21-rc6/drivers/pci/pci-acpi.c 2007-04-25 10:58:12.000000000 +0800
> @@ -317,6 +317,10 @@ static int __init acpi_pci_init(void)
> {
> int ret;
>
> + if (acpi_gbl_FADT.boot_flags & BAF_MSI_NOT_SUPPORTED) {
> + printk(KERN_INFO"ACPI FADT declares the system doesn't support MSI, so disable it\n");
> + pci_no_msi();
> + }
> ret = register_acpi_bus_type(&acpi_pci_bus);
> if (ret)
> return 0;
> Index: 2.6.21-rc6/include/acpi/actbl.h
> ===================================================================
> --- 2.6.21-rc6.orig/include/acpi/actbl.h 2007-04-06 10:36:56.000000000 +0800
> +++ 2.6.21-rc6/include/acpi/actbl.h 2007-04-25 10:22:28.000000000 +0800
> @@ -276,6 +276,7 @@ enum acpi_prefered_pm_profiles {
>
> #define BAF_LEGACY_DEVICES 0x0001
> #define BAF_8042_KEYBOARD_CONTROLLER 0x0002
> +#define BAF_MSI_NOT_SUPPORTED 0x0008
>
> #define FADT2_REVISION_ID 3
> #define FADT2_MINUS_REVISION_ID 2
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
prev parent reply other threads:[~2007-04-25 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-25 3:05 [PATCH] Disable MSI per FADT Shaohua Li
2007-04-25 5:14 ` Len Brown
2007-04-25 15:01 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070425080110.ab2bbe5f.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=greg@kroah.com \
--cc=hmh@hmh.eng.br \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox