From: Len Brown <lenb@kernel.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: linux-acpi@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch] ACPI: use _STA bit names rather than 0x0F
Date: Wed, 25 Apr 2007 14:21:04 -0400 [thread overview]
Message-ID: <200704251421.04766.lenb@kernel.org> (raw)
In-Reply-To: <200704201056.51472.bjorn.helgaas@hp.com>
Applied.
thanks,
-Len
On Friday 20 April 2007 12:56, Bjorn Helgaas wrote:
> Be explicit about what "device->status = 0x0F" really means.
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
>
> Index: w/drivers/acpi/scan.c
> ===================================================================
> --- w.orig/drivers/acpi/scan.c 2007-04-19 21:35:42.000000000 -0600
> +++ w/drivers/acpi/scan.c 2007-04-19 21:36:50.000000000 -0600
> @@ -1068,7 +1068,9 @@
> }
> break;
> default:
> - STRUCT_TO_INT(device->status) = 0x0F;
> + STRUCT_TO_INT(device->status) =
> + ACPI_STA_DEVICE_PRESENT | ACPI_STA_DEVICE_ENABLED |
> + ACPI_STA_DEVICE_UI | ACPI_STA_DEVICE_FUNCTIONING;
> break;
> }
>
> Index: w/drivers/acpi/bus.c
> ===================================================================
> --- w.orig/drivers/acpi/bus.c 2007-04-19 21:35:42.000000000 -0600
> +++ w/drivers/acpi/bus.c 2007-04-19 21:37:52.000000000 -0600
> @@ -103,7 +103,9 @@
> else if (device->parent)
> device->status = device->parent->status;
> else
> - STRUCT_TO_INT(device->status) = 0x0F;
> + STRUCT_TO_INT(device->status) =
> + ACPI_STA_DEVICE_PRESENT | ACPI_STA_DEVICE_ENABLED |
> + ACPI_STA_DEVICE_UI | ACPI_STA_DEVICE_FUNCTIONING;
>
> if (device->status.functional && !device->status.present) {
> printk(KERN_WARNING PREFIX "Device [%s] status [%08x]: "
>
prev parent reply other threads:[~2007-04-25 18:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-20 16:56 [patch] ACPI: use _STA bit names rather than 0x0F Bjorn Helgaas
2007-04-25 18:21 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704251421.04766.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox