* [patch] ACPI: use _STA bit names rather than 0x0F
@ 2007-04-20 16:56 Bjorn Helgaas
2007-04-25 18:21 ` Len Brown
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Helgaas @ 2007-04-20 16:56 UTC (permalink / raw)
To: Len Brown; +Cc: linux-acpi, Andrew Morton
Be explicit about what "device->status = 0x0F" really means.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: w/drivers/acpi/scan.c
===================================================================
--- w.orig/drivers/acpi/scan.c 2007-04-19 21:35:42.000000000 -0600
+++ w/drivers/acpi/scan.c 2007-04-19 21:36:50.000000000 -0600
@@ -1068,7 +1068,9 @@
}
break;
default:
- STRUCT_TO_INT(device->status) = 0x0F;
+ STRUCT_TO_INT(device->status) =
+ ACPI_STA_DEVICE_PRESENT | ACPI_STA_DEVICE_ENABLED |
+ ACPI_STA_DEVICE_UI | ACPI_STA_DEVICE_FUNCTIONING;
break;
}
Index: w/drivers/acpi/bus.c
===================================================================
--- w.orig/drivers/acpi/bus.c 2007-04-19 21:35:42.000000000 -0600
+++ w/drivers/acpi/bus.c 2007-04-19 21:37:52.000000000 -0600
@@ -103,7 +103,9 @@
else if (device->parent)
device->status = device->parent->status;
else
- STRUCT_TO_INT(device->status) = 0x0F;
+ STRUCT_TO_INT(device->status) =
+ ACPI_STA_DEVICE_PRESENT | ACPI_STA_DEVICE_ENABLED |
+ ACPI_STA_DEVICE_UI | ACPI_STA_DEVICE_FUNCTIONING;
if (device->status.functional && !device->status.present) {
printk(KERN_WARNING PREFIX "Device [%s] status [%08x]: "
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] ACPI: use _STA bit names rather than 0x0F
2007-04-20 16:56 [patch] ACPI: use _STA bit names rather than 0x0F Bjorn Helgaas
@ 2007-04-25 18:21 ` Len Brown
0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2007-04-25 18:21 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-acpi, Andrew Morton
Applied.
thanks,
-Len
On Friday 20 April 2007 12:56, Bjorn Helgaas wrote:
> Be explicit about what "device->status = 0x0F" really means.
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
>
> Index: w/drivers/acpi/scan.c
> ===================================================================
> --- w.orig/drivers/acpi/scan.c 2007-04-19 21:35:42.000000000 -0600
> +++ w/drivers/acpi/scan.c 2007-04-19 21:36:50.000000000 -0600
> @@ -1068,7 +1068,9 @@
> }
> break;
> default:
> - STRUCT_TO_INT(device->status) = 0x0F;
> + STRUCT_TO_INT(device->status) =
> + ACPI_STA_DEVICE_PRESENT | ACPI_STA_DEVICE_ENABLED |
> + ACPI_STA_DEVICE_UI | ACPI_STA_DEVICE_FUNCTIONING;
> break;
> }
>
> Index: w/drivers/acpi/bus.c
> ===================================================================
> --- w.orig/drivers/acpi/bus.c 2007-04-19 21:35:42.000000000 -0600
> +++ w/drivers/acpi/bus.c 2007-04-19 21:37:52.000000000 -0600
> @@ -103,7 +103,9 @@
> else if (device->parent)
> device->status = device->parent->status;
> else
> - STRUCT_TO_INT(device->status) = 0x0F;
> + STRUCT_TO_INT(device->status) =
> + ACPI_STA_DEVICE_PRESENT | ACPI_STA_DEVICE_ENABLED |
> + ACPI_STA_DEVICE_UI | ACPI_STA_DEVICE_FUNCTIONING;
>
> if (device->status.functional && !device->status.present) {
> printk(KERN_WARNING PREFIX "Device [%s] status [%08x]: "
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-04-25 18:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-20 16:56 [patch] ACPI: use _STA bit names rather than 0x0F Bjorn Helgaas
2007-04-25 18:21 ` Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox