From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: Thinkpad suspend-to-disk regression Date: Wed, 25 Apr 2007 14:47:52 +0200 Message-ID: <200704251447.53288.rjw@sisk.pl> References: <3d7cf86d0704241129i23da1b9fq93876573618e9dcd@mail.gmail.com> <200704250032.11108.rjw@sisk.pl> <3d7cf86d0704241925u61b46ac0m2df1f5ac194832b@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from ogre.sisk.pl ([217.79.144.158]:42618 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965573AbXDYMn7 (ORCPT ); Wed, 25 Apr 2007 08:43:59 -0400 In-Reply-To: <3d7cf86d0704241925u61b46ac0m2df1f5ac194832b@mail.gmail.com> Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Guilherme Salgado Cc: linux-acpi@vger.kernel.org On Wednesday, 25 April 2007 04:25, Guilherme Salgado wrote: > On 4/24/07, Rafael J. Wysocki wrote: > > On Tuesday, 24 April 2007 20:29, Guilherme Salgado wrote: > > > (I've already sent this to linux-acpi but got no response so far, so I > > > thought it could be a good idea to send directly to you) > > > > > > Hi there, > > > > > > I recently noticed that my thinkpad T60 would lose the sound after > > > being suspended to disk (https://launchpad.net/bugs/80893), requiring > > > a cold restart to fix it. After some git-bisect work I found this > > > regression was a consequence of > > > http://git.kernel.org/?p=linux/kernel/git/lenb/linux-acpi-2.6.git;a=commitdiff;h=9185cfa92507d07ac787bc73d06c42222eec7239 > > > (patch inlined here) > > > > > > Is there any chance of fixing the regression this introduced without > > > reverting it? Please let me know if you want any other info or have a > > > patch for me to try. > > > > You don't need a patch, I think. Please try > > > > # echo shutdown > /sys/power/disk > > > > before the suspend (assuming you use the built-in swsusp). If that works, > > just make your configuration scripts echo 'shutdown' to /sys/power/disk at > > system startup. > > > > I use Ubuntu's default /etc/acpi/hibernate.sh, which already sets > /sys/power/disk to shutdown before echoing "disk" to /sys/power/state. In that case it's impossible that the commit you have identified causes the problem to happen. It doesn't even touch the 'shutdown' code path. Greetings, Rafael