From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@linux-foundation.org>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
lenb@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: [-mm patch] make drivers/misc/thinkpad_acpi:fan_mutex static
Date: Sat, 28 Apr 2007 21:19:38 +0200 [thread overview]
Message-ID: <20070428191938.GO3468@stusta.de> (raw)
In-Reply-To: <20070425225716.8e9b28ca.akpm@linux-foundation.org>
On Wed, Apr 25, 2007 at 10:57:16PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.21-rc7-mm1:
>...
> git-acpi.patch
>...
> git trees
>...
This patch makes the needlessly global fan_mutex static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
BTW: Prototypes for static versions and static variables in a header
file are really wrong, but the mess is bigger than what I'm
willing to clean up...
--- linux-2.6.21-rc7-mm2/drivers/misc/thinkpad_acpi.h.old 2007-04-27 00:55:58.000000000 +0200
+++ linux-2.6.21-rc7-mm2/drivers/misc/thinkpad_acpi.h 2007-04-28 01:32:54.000000000 +0200
@@ -382,7 +382,7 @@
static u8 fan_control_desired_level;
static int fan_watchdog_maxinterval;
-struct mutex fan_mutex;
+static struct mutex fan_mutex;
static acpi_handle fans_handle, gfan_handle, sfan_handle;
next parent reply other threads:[~2007-04-28 19:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070425225716.8e9b28ca.akpm@linux-foundation.org>
2007-04-28 19:19 ` Adrian Bunk [this message]
2007-04-28 19:58 ` [-mm patch] make drivers/misc/thinkpad_acpi:fan_mutex static Henrique de Moraes Holschuh
2007-04-29 1:53 ` Len Brown
2007-04-29 2:50 ` Adrian Bunk
2007-04-29 4:09 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070428191938.GO3468@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@linux-foundation.org \
--cc=hmh@hmh.eng.br \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox