Re: [patch 2.6.21-git] pci_choose_state() works, does ACPI magic

[David Brownell <david-b@pacbell.net>]

On Thursday 10 May 2007, Rafael J. Wysocki wrote:
> On Wednesday, 9 May 2007 21:22, David Brownell wrote:
> > Provide new ACPI method tracking the target system state, for use
> > during suspend() and other PM calls.  It returns ACPI_STATE_S0
> > except during true suspend paths.
> > 
> > Use that to finally implement the platform_pci_choose_state() hook
> > on ACPI platforms.  It calls "_S3D" and similar methods, and uses
> > the result appropriately.
> > 
> > Fix pci_choose_state() to finally behave sanely too.
> > 
> > ...
> > 
> > ---
> >  drivers/acpi/sleep/main.c |   29 +++++++++++-
> >  drivers/pci/pci-acpi.c    |  107 +++++++++++++++++++++++++++++++++-------------
> >  drivers/pci/pci.c         |   51 ++++++++++++---------
> >  include/acpi/acpixf.h     |    2 
> >  4 files changed, 135 insertions(+), 54 deletions(-)
> > 
> > ...
> 
> I guess we'll need an analogous change for the hibernation too?

I guess so too.  This probably isn't in shape to merge, because
of those changes to split hibernation out; and not enough testing.
So far as I know, those are the only real issues with this patch.

- Dave