public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Pavel Machek <pavel@ucw.cz>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>,
	Alexey Starikovskiy <aystarik@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>
Subject: [RFC][PATCH 0/4] swsusp: Fix hibernation/restore code ordering
Date: Fri, 18 May 2007 00:19:34 +0200	[thread overview]
Message-ID: <200705180019.35548.rjw@sisk.pl> (raw)

Hi,

In the face of this change:

http://marc.info/?l=linux-acpi&m=117938245931603&w=2

I think we should also modify the code ordering in swsusp so that
hibernation_ops->prepare() is executed after device_suspend().

However, for this purpose it seems reasonable to eliminate the code duplication
between kernel/power/disk.c and kernel/power/user.c first.  By eliminating it
we can reduce the size of user.c quite substantially and remove the
maintenance difficulty with making essentially the same changes in two
different places.

Moreover, we should also remove the calls to "platform" functions from the
restore code path, since it doesn't carry out any power transition of the
system, but we generally need to disable the GPEs before the restore if the
'platform' hibernation mode has been used.  To do this, we can introduce
two new hibernation_ops to be used in the restore code.

Comments welcome.

Greetings,
Rafael


-- 
If you don't have the time to read,
you don't have the time or the tools to write.
		- Stephen King


             reply	other threads:[~2007-05-17 22:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-17 22:19 Rafael J. Wysocki [this message]
2007-05-17 22:21 ` [RFC][PATCH 1/4] swsusp: Remove incorrect code from user.c Rafael J. Wysocki
2007-05-21 23:29   ` Pavel Machek
2007-05-17 22:22 ` [RFC][PATCH 2/4] swsusp: Remove code duplication between disk.c and user.c Rafael J. Wysocki
2007-05-21 23:30   ` Pavel Machek
2007-05-17 22:24 ` [RFC][PATCH 3/4] swsusp: Introduce restore platform operations Rafael J. Wysocki
2007-05-21 23:38   ` Pavel Machek
2007-05-21 23:55     ` Rafael J. Wysocki
2007-05-22 20:03       ` Rafael J. Wysocki
2007-05-22 20:10         ` Alexey Starikovskiy
2007-05-22 20:30           ` Rafael J. Wysocki
2007-05-17 22:26 ` [RFC][PATCH 4/4] swsusp: Fix hibernation code ordering Rafael J. Wysocki
2007-05-19  8:36   ` [RFC][PATCH 4/4] swsusp: Fix hibernation code ordering (updated) Rafael J. Wysocki
2007-05-21 23:31     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705180019.35548.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=aystarik@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox