public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Pavel Machek <pavel@ucw.cz>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>,
	Alexey Starikovskiy <aystarik@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>
Subject: [RFC][PATCH 4/4] swsusp: Fix hibernation code ordering
Date: Fri, 18 May 2007 00:26:20 +0200	[thread overview]
Message-ID: <200705180026.20647.rjw@sisk.pl> (raw)
In-Reply-To: <200705180019.35548.rjw@sisk.pl>

From: Rafael J. Wysocki <rjw@sisk.pl>

Change the code ordering so that hibernation_ops->prepare() is called after
device_suspend().  This is needed so that we don't violate the ACPI
specification, which states that the _PTS and _GTS system-control methods,
executed from acpi_sleep_prepare(), ought to be called after devices have been
put in low power states.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 kernel/power/disk.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Index: linux-2.6.22-rc1/kernel/power/disk.c
===================================================================
--- linux-2.6.22-rc1.orig/kernel/power/disk.c	2007-05-17 22:53:27.000000000 +0200
+++ linux-2.6.22-rc1/kernel/power/disk.c	2007-05-17 22:56:24.000000000 +0200
@@ -135,15 +135,15 @@ int hibernation_snapshot(int platform_mo
 	if (error)
 		goto Finish;
 
-	error = platform_prepare(platform_mode);
-	if (error)
-		goto Finish;
-
 	suspend_console();
 	error = device_suspend(PMSG_FREEZE);
 	if (error)
 		goto Resume_devices;
 
+	error = platform_prepare(platform_mode);
+	if (error)
+		goto Resume_devices;
+
 	error = disable_nonboot_cpus();
 	if (!error) {
 		if (hibernation_mode != HIBERNATION_TEST) {

  parent reply	other threads:[~2007-05-17 22:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-17 22:19 [RFC][PATCH 0/4] swsusp: Fix hibernation/restore code ordering Rafael J. Wysocki
2007-05-17 22:21 ` [RFC][PATCH 1/4] swsusp: Remove incorrect code from user.c Rafael J. Wysocki
2007-05-21 23:29   ` Pavel Machek
2007-05-17 22:22 ` [RFC][PATCH 2/4] swsusp: Remove code duplication between disk.c and user.c Rafael J. Wysocki
2007-05-21 23:30   ` Pavel Machek
2007-05-17 22:24 ` [RFC][PATCH 3/4] swsusp: Introduce restore platform operations Rafael J. Wysocki
2007-05-21 23:38   ` Pavel Machek
2007-05-21 23:55     ` Rafael J. Wysocki
2007-05-22 20:03       ` Rafael J. Wysocki
2007-05-22 20:10         ` Alexey Starikovskiy
2007-05-22 20:30           ` Rafael J. Wysocki
2007-05-17 22:26 ` Rafael J. Wysocki [this message]
2007-05-19  8:36   ` [RFC][PATCH 4/4] swsusp: Fix hibernation code ordering (updated) Rafael J. Wysocki
2007-05-21 23:31     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705180026.20647.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=aystarik@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox