From mboxrd@z Thu Jan 1 00:00:00 1970 From: Len Brown Subject: Re: [PATCH] Show devices for active/passive cooling in thermal trip_points file Date: Sun, 20 May 2007 18:55:37 -0400 Message-ID: <200705201855.38039.lenb@kernel.org> References: <1163973700.3562.13.camel@sublime.site> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from hera.kernel.org ([140.211.167.34]:50011 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757681AbXETW5A (ORCPT ); Sun, 20 May 2007 18:57:00 -0400 In-Reply-To: <1163973700.3562.13.camel@sublime.site> Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: trenn@suse.de Cc: linux-acpi@vger.kernel.org, fseidel@suse.de, Arjan van de Ven , "Zhang, Rui" Applied a refreshed version of this patch. (thought I had done so a while ago) thanks, -Len On Sunday 19 November 2006 17:01, Thomas Renninger wrote: > Len, can you queue this one for after 2.6.19 inclusion, please. > With this and a firmwarekit test it should be possible to identify > not working fans as it happened on some HPs in 2.6.16 and later > automatically. > > Thanks, > > Thomas > > Show devices for active/passive cooling in thermal trip_points file > > Currently the internal pointer to a ACPI handle of a device > which is used for active/passive cooling at a certain temperature > is exported to userspace. This pointer isn't of any use for userspace. > > Instead, export the device name, so > that automated tests (e.g. linuxfirmwarekit) can check whether the > device (at least fans for active cooling trip points) really get activated > on the right temperature. > > Signed-off-by: Thomas Renninger > > drivers/acpi/thermal.c | 13 +++++++------ > 1 files changed, 7 insertions(+), 6 deletions(-) > > Index: linux-2.6.19-rc6/drivers/acpi/thermal.c > =================================================================== > --- linux-2.6.19-rc6.orig/drivers/acpi/thermal.c > +++ linux-2.6.19-rc6/drivers/acpi/thermal.c > @@ -838,6 +838,7 @@ static int acpi_thermal_temp_open_fs(str > static int acpi_thermal_trip_seq_show(struct seq_file *seq, void *offset) > { > struct acpi_thermal *tz = (struct acpi_thermal *)seq->private; > + struct acpi_device *device; > int i = 0; > int j = 0; > > @@ -860,9 +861,8 @@ static int acpi_thermal_trip_seq_show(st > tz->trips.passive.tc1, tz->trips.passive.tc2, > tz->trips.passive.tsp); > for (j = 0; j < tz->trips.passive.devices.count; j++) { > - > - seq_printf(seq, "0x%p ", > - tz->trips.passive.devices.handles[j]); > + acpi_bus_get_device(tz->trips.passive.devices.handles[j], &device); > + seq_printf(seq, "%4.4s ", acpi_device_bid(device)); > } > seq_puts(seq, "\n"); > } > @@ -873,9 +873,10 @@ static int acpi_thermal_trip_seq_show(st > seq_printf(seq, "active[%d]: %ld C: devices=", > i, > KELVIN_TO_CELSIUS(tz->trips.active[i].temperature)); > - for (j = 0; j < tz->trips.active[i].devices.count; j++) > - seq_printf(seq, "0x%p ", > - tz->trips.active[i].devices.handles[j]); > + for (j = 0; j < tz->trips.active[i].devices.count; j++){ > + acpi_bus_get_device(tz->trips.active[i].devices.handles[j], &device); > + seq_printf(seq, "%4.4s ", acpi_device_bid(device)); > + } > seq_puts(seq, "\n"); > } > > > > > - > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >