Re: [patch 2.6.21-git] pci_choose_state() works, does ACPI magic

[David Brownell <david-b@pacbell.net>]

On Monday 21 May 2007, Bjorn Helgaas wrote:
> On Monday 21 May 2007 11:55:54 am David Brownell wrote:
> > On Monday 21 May 2007, Bjorn Helgaas wrote:
> > > We had a bug[1] a while back where e1000 would suspend a device and
> > > call pci_power_state(), which used ACPI to turn off the slot.  The
> > > only problem was that this was a dual-port card and the other port
> > > was still active when the lights went out.
> > 
> > Sounds like an ACPI bug to me:  not properly tracking the users
> > of a given PCI power resource.
> 
> acpi_bus_set_power() takes a "handle", which refers to the slot.

Odd; elsewhere the "handle" refers to a single logical device,
and that's normally been a single function.  And the examples
in the Microsoft doc you mentioned show that structure too.

Of course, I'm not used to seeing ACPI look at devices in slots
either ... usually it just tells me about things on the mainboard.
It seems hotplug PCI needs work yet.

... Regardless, this pre-existing problem wasn't affected by
the $SUBJECT patch.

- Dave


>   http://www.microsoft.com/whdc/system/pnppwr/hotadd/hotplugpci.mspx
> 
> > > [1] https://bugzilla.novell.com/show_bug.cgi?id=162320
>