From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>,
Alexey Starikovskiy <aystarik@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [RFC][PATCH 4/4] swsusp: Fix hibernation code ordering (updated)
Date: Tue, 22 May 2007 01:31:38 +0200 [thread overview]
Message-ID: <20070521233138.GL10714@elf.ucw.cz> (raw)
In-Reply-To: <200705191036.58177.rjw@sisk.pl>
Hi!
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Change the code ordering so that hibernation_ops->prepare() is called after
> device_suspend(). This is needed so that we don't violate the ACPI
> specification, which states that the _PTS and _GTS system-control methods,
> executed from acpi_sleep_prepare(), ought to be called after devices have been
> put in low power states.
>
> The "Finish" label in hibernation_restore() is moved, because device_suspend()
> resumes devices if the suspending of them fails and the restore code ordering
> should reflect the hibernation code ordering.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
ACK.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2007-05-21 23:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 22:19 [RFC][PATCH 0/4] swsusp: Fix hibernation/restore code ordering Rafael J. Wysocki
2007-05-17 22:21 ` [RFC][PATCH 1/4] swsusp: Remove incorrect code from user.c Rafael J. Wysocki
2007-05-21 23:29 ` Pavel Machek
2007-05-17 22:22 ` [RFC][PATCH 2/4] swsusp: Remove code duplication between disk.c and user.c Rafael J. Wysocki
2007-05-21 23:30 ` Pavel Machek
2007-05-17 22:24 ` [RFC][PATCH 3/4] swsusp: Introduce restore platform operations Rafael J. Wysocki
2007-05-21 23:38 ` Pavel Machek
2007-05-21 23:55 ` Rafael J. Wysocki
2007-05-22 20:03 ` Rafael J. Wysocki
2007-05-22 20:10 ` Alexey Starikovskiy
2007-05-22 20:30 ` Rafael J. Wysocki
2007-05-17 22:26 ` [RFC][PATCH 4/4] swsusp: Fix hibernation code ordering Rafael J. Wysocki
2007-05-19 8:36 ` [RFC][PATCH 4/4] swsusp: Fix hibernation code ordering (updated) Rafael J. Wysocki
2007-05-21 23:31 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070521233138.GL10714@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=aystarik@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox