Re: [RFC][PATCH 4/4] swsusp: Fix hibernation code ordering (updated)

Pavel Machek
2007-05-21T23:31:46Z

Hi!

> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Change the code ordering so that hibernation_ops->prepare() is called after
> device_suspend(). This is needed so that we don't violate the ACPI
> specification, which states that the _PTS and _GTS system-control methods,
> executed from acpi_sleep_prepare(), ought to be called after devices have been
> put in low power states.
>
> The "Finish" label in hibernation_restore() is moved, because device_suspend()
> resumes devices if the suspending of them fails and the restore code ordering
> should reflect the hibernation code ordering.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

ACK.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html