From: Len Brown <lenb@kernel.org>
To: Luming Yu <luming.yu@gmail.com>
Cc: linux-acpi@vger.kernel.org
Subject: Re: [PATCH] _TPC,_TSS,_PTC support
Date: Sat, 2 Jun 2007 00:35:44 -0400 [thread overview]
Message-ID: <200706020035.44136.lenb@kernel.org> (raw)
In-Reply-To: <3877989d0705260749y1fd55beau899f25b39e881d5a@mail.gmail.com>
a couple places use local_irq_disable/local_irq_enable
but it isn't obvious why interrupts need to be disabled.
also, wouldn't it be safer to use local_irq_save/local_irq_restore
in the event the code is used with interrupts off?
Applied to acpi-test (and then Lindented:-)
thanks,
-Len
prev parent reply other threads:[~2007-06-02 4:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-26 14:49 [PATCH] _TPC,_TSS,_PTC support Luming Yu
2007-06-02 4:35 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706020035.44136.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=luming.yu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox