Re: [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE

Christoph Hellwig
2007-05-31T09:56:10Z

On Wed, May 30, 2007 at 03:25:05PM -0400, Len Brown wrote:
>
> > > Any reason to not just replace ACPI_RSD_TABLE_SIZE with ARRAY_SIZE?
>
> Probably because ARRAY_SIZE doesn't exist in ACPICA, which is
> where this code comes from...
>
> When we change syntax in ACPICA files in Linux to make it more "beautiful",
> then it creates more work for me -- as forever on, that syntax difference
> must be manually compared to upstream ACPICA and Linux -- and that syntax
> difference causes upstream patches to no longer apply and require
> hand merging.

Or we could stop that ACPCICA crap ASAP. The acpi code not only looks
like crap because of that but it's buggy as hell now.

Intel is claiming how great linux is and how supportive is to it, but
can't even write proper code for their abomination of a firmware standard.
This is really more than dishonest. Please take patches to get acpi into
shape and stop this complaining.