public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Len Brown <lenb@kernel.org>
Cc: Andreas Herrmann <andreas.herrmann3@amd.com>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 7/12] acpi: fix another compile warning
Date: Tue, 19 Jun 2007 20:49:34 -0700	[thread overview]
Message-ID: <20070619204934.f56722a8.randy.dunlap@oracle.com> (raw)
In-Reply-To: <200706192338.02807.lenb@kernel.org>

On Tue, 19 Jun 2007 23:38:02 -0400 Len Brown wrote:

> On Tuesday 19 June 2007 18:50, Andreas Herrmann wrote:
> > Avoid compile warning if !ACPI_BLACKLIST_YEAR
> > 
> >   CC      drivers/acpi/blacklist.o
> >   drivers/acpi/blacklist.c:76:5: warning: "CONFIG_ACPI_BLACKLIST_YEAR" is not defined
> 
> How were you able to produce a .config with CONFIG_ACPI_BLACKLIST_YEAR not defined?
> Can you send it to me?

'make randconfig' does that kind of thing.  It doesn't enforce/follow
"select" clauses.


> thanks,
> -Len
> 
> > Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
> > ---
> >  drivers/acpi/blacklist.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
> > index 3ec110c..ac96c47 100644
> > --- a/drivers/acpi/blacklist.c
> > +++ b/drivers/acpi/blacklist.c
> > @@ -73,7 +73,7 @@ static struct acpi_blacklist_item acpi_blacklist[] __initdata = {
> >  	{""}
> >  };
> >  
> > -#if	CONFIG_ACPI_BLACKLIST_YEAR
> > +#if	defined(CONFIG_ACPI_BLACKLIST_YEAR) && CONFIG_ACPI_BLACKLIST_YEAR
> >  
> >  static int __init blacklist_by_year(void)
> >  {
> -

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  reply	other threads:[~2007-06-20  3:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-19 22:50 [PATCH 7/12] acpi: fix another compile warning Andreas Herrmann
2007-06-20  3:38 ` Len Brown
2007-06-20  3:49   ` Randy Dunlap [this message]
2007-06-20  3:51     ` Randy Dunlap
2007-06-20  4:41       ` Len Brown
2007-06-20  9:31       ` Andreas Herrmann
2007-06-20 14:28         ` Randy Dunlap
2007-06-20  8:49   ` Andreas Herrmann
2007-06-20 13:36     ` Len Brown
2007-06-20 13:46       ` Andi Kleen
2007-06-20 18:25       ` Ravikiran G Thirumalai
2007-06-21 18:36         ` Andreas Herrmann
2007-06-22 14:39           ` Andreas Herrmann
2007-06-23  3:55         ` Andrew Morton
2007-06-23  4:28           ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070619204934.f56722a8.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=andreas.herrmann3@amd.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox