From: Len Brown <lenb@kernel.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andreas Herrmann <andreas.herrmann3@amd.com>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 7/12] acpi: fix another compile warning
Date: Wed, 20 Jun 2007 00:41:42 -0400 [thread overview]
Message-ID: <200706200041.42596.lenb@kernel.org> (raw)
In-Reply-To: <20070619205158.8d6da762.randy.dunlap@oracle.com>
On Tuesday 19 June 2007 23:51, Randy Dunlap wrote:
> On Tue, 19 Jun 2007 20:49:34 -0700 Randy Dunlap wrote:
>
> > On Tue, 19 Jun 2007 23:38:02 -0400 Len Brown wrote:
> >
> > > On Tuesday 19 June 2007 18:50, Andreas Herrmann wrote:
> > > > Avoid compile warning if !ACPI_BLACKLIST_YEAR
> > > >
> > > > CC drivers/acpi/blacklist.o
> > > > drivers/acpi/blacklist.c:76:5: warning: "CONFIG_ACPI_BLACKLIST_YEAR" is not defined
> > >
> > > How were you able to produce a .config with CONFIG_ACPI_BLACKLIST_YEAR not defined?
> > > Can you send it to me?
> >
> > 'make randconfig' does that kind of thing. It doesn't enforce/follow
> > "select" clauses.
>
> I should have also said: randconfig is good for detecting some
> missing conditions/configs or missing header files, but if you find one
> that is just plain Invalid (like some of these), just say so
> and do whatever you want with the patch (IMHO of course).
If randconfig ends up with impossible-for-a-user-to-generate configs,
then it seems seriously broken. Perhaps it would make sense to run
"make oldconfig" after "make randconfig" -- or better yet, have that
built in?
-Len
next prev parent reply other threads:[~2007-06-20 4:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 22:50 [PATCH 7/12] acpi: fix another compile warning Andreas Herrmann
2007-06-20 3:38 ` Len Brown
2007-06-20 3:49 ` Randy Dunlap
2007-06-20 3:51 ` Randy Dunlap
2007-06-20 4:41 ` Len Brown [this message]
2007-06-20 9:31 ` Andreas Herrmann
2007-06-20 14:28 ` Randy Dunlap
2007-06-20 8:49 ` Andreas Herrmann
2007-06-20 13:36 ` Len Brown
2007-06-20 13:46 ` Andi Kleen
2007-06-20 18:25 ` Ravikiran G Thirumalai
2007-06-21 18:36 ` Andreas Herrmann
2007-06-22 14:39 ` Andreas Herrmann
2007-06-23 3:55 ` Andrew Morton
2007-06-23 4:28 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706200041.42596.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=andreas.herrmann3@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox