public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Len Brown <lenb@kernel.org>
Cc: Andreas Herrmann <andreas.herrmann3@amd.com>,
	Steven Whitehouse <swhiteho@redhat.com>,
	Shai Fultheim <shai@scalex86.org>,
	Ravikiran Thirumalai <kiran@scalex86.org>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 7/12] acpi: fix another compile warning
Date: Wed, 20 Jun 2007 15:46:28 +0200	[thread overview]
Message-ID: <200706201546.28457.ak@suse.de> (raw)
In-Reply-To: <200706200936.31236.lenb@kernel.org>


> The underlying problem is that Kconfig doesn't support using select
> on targets which themselves have dependencies.
> 
> Signed-off-by: Len Brown <len.brown@intel.com>

The depends on ACPI is fine by me, but I would prefer if the 
ACPI_NUMA dependency worked the other way round (APCI_NUMA default y
and depends on the relevant architecture specific symbols). That would
be more user friendly I think because all the NUMA options would
be in one place.

-Andi

> diff --git a/arch/x86_64/Kconfig b/arch/x86_64/Kconfig
> index 5ce9443..e9d7767 100644
> --- a/arch/x86_64/Kconfig
> +++ b/arch/x86_64/Kconfig
> @@ -364,9 +364,9 @@ config NODES_SHIFT
>  config X86_64_ACPI_NUMA
>         bool "ACPI NUMA detection"
>         depends on NUMA
> -       select ACPI 
> +       depends on ACPI 
>  	select PCI
> -       select ACPI_NUMA
> +       depends on ACPI_NUMA
>         default y
>         help
>  	 Enable ACPI SRAT based node topology detection.
> 



  reply	other threads:[~2007-06-20 13:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-19 22:50 [PATCH 7/12] acpi: fix another compile warning Andreas Herrmann
2007-06-20  3:38 ` Len Brown
2007-06-20  3:49   ` Randy Dunlap
2007-06-20  3:51     ` Randy Dunlap
2007-06-20  4:41       ` Len Brown
2007-06-20  9:31       ` Andreas Herrmann
2007-06-20 14:28         ` Randy Dunlap
2007-06-20  8:49   ` Andreas Herrmann
2007-06-20 13:36     ` Len Brown
2007-06-20 13:46       ` Andi Kleen [this message]
2007-06-20 18:25       ` Ravikiran G Thirumalai
2007-06-21 18:36         ` Andreas Herrmann
2007-06-22 14:39           ` Andreas Herrmann
2007-06-23  3:55         ` Andrew Morton
2007-06-23  4:28           ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706201546.28457.ak@suse.de \
    --to=ak@suse.de \
    --cc=andreas.herrmann3@amd.com \
    --cc=kiran@scalex86.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shai@scalex86.org \
    --cc=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox