From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Andreas Herrmann" Subject: Re: [PATCH 2/12] acpi: select ACPI_EC for THINKPAD_ACPI Date: Fri, 22 Jun 2007 16:47:50 +0200 Message-ID: <20070622144750.GV5193@alberich.amd.com> References: <20070619224836.GD5193@alberich.amd.com> <20070620005744.GA15080@khazad-dum.debian.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from outbound-blu.frontbridge.com ([65.55.251.16]:25571 "EHLO outbound7-blu-R.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756432AbXFVOq6 (ORCPT ); Fri, 22 Jun 2007 10:46:58 -0400 In-Reply-To: <20070620005744.GA15080@khazad-dum.debian.net> Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Henrique de Moraes Holschuh Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org On Tue, Jun 19, 2007 at 09:57:44PM -0300, Henrique de Moraes Holschuh wrote: > On Wed, 20 Jun 2007, Andreas Herrmann wrote: > > Fix kernel build problem: > > > > thinkpad_acpi.c:(.text+0x7486a): undefined reference to `ec_write' > > > > (as THINKPAD_ACPI depends on ACPI_EC) > > > > Signed-off-by: Andreas Herrmann > > --- > > drivers/misc/Kconfig | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > > index 2f2fbff..72774c9 100644 > > --- a/drivers/misc/Kconfig > > +++ b/drivers/misc/Kconfig > > @@ -139,6 +139,7 @@ config SONYPI_COMPAT > > config THINKPAD_ACPI > > tristate "ThinkPad ACPI Laptop Extras" > > depends on X86 && ACPI > > + select ACPI_EC > > select BACKLIGHT_CLASS_DEVICE > > select HWMON > > ---help--- > > Acked-by: Henrique de Moraes Holschuh > Well, this one shouldn't be applied. The problem is better fixed in arch/x86_64/Kconfig. BTW, the above patch would lead to kconfig warnings on non x86-architectures. A proper version would be to add "select ACPI_EC if X86". Regards, Andreas -- Operating | AMD Saxony Limited Liability Company & Co. KG, System | Wilschdorfer Landstr. 101, 01109 Dresden, Germany Research | Register Court Dresden: HRA 4896, General Partner authorized Center | to represent: AMD Saxony LLC (Wilmington, Delaware, US) (OSRC) | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy