public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Ravikiran G Thirumalai <kiran@scalex86.org>
Cc: lenb@kernel.org, andreas.herrmann3@amd.com, swhiteho@redhat.com,
	ak@suse.de, shai@scalex86.org, linux-kernel@vger.kernel.org,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH 7/12] acpi: fix another compile warning
Date: Fri, 22 Jun 2007 20:55:30 -0700	[thread overview]
Message-ID: <20070622205530.964ebef9.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070620182548.GA561@localdomain>

> On Wed, 20 Jun 2007 11:25:48 -0700 Ravikiran G Thirumalai <kiran@scalex86.org> wrote:
> Paper over 'select' inadequacies.  
> 
> Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>
> 
> Index: linux-2.6.22-rc5/arch/x86_64/Kconfig
> ===================================================================
> --- linux-2.6.22-rc5.orig/arch/x86_64/Kconfig	2007-06-18 16:02:19.571323415 -0700
> +++ linux-2.6.22-rc5/arch/x86_64/Kconfig	2007-06-20 11:34:29.845354250 -0700
> @@ -366,6 +366,7 @@ config X86_64_ACPI_NUMA
>         depends on NUMA
>         select ACPI 
>  	select PCI
> +  	select PM
>         select ACPI_NUMA
>         default y
>         help

argh.  (and not just argh-at-your-email-client).

I went through some hair-tearing a few months ago working out why it is so
damn hard to make CONFIG_PM go away and then I fixed it.  And now you're
proposing a change which would reinstate the obnoxious old behaviour.

Is the "bug" which you're "fixing" here caused by the randconfig
inadequacies?  Because randconfig is just busted and simply should auto-run
oldconfig.

  parent reply	other threads:[~2007-06-23  3:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-19 22:50 [PATCH 7/12] acpi: fix another compile warning Andreas Herrmann
2007-06-20  3:38 ` Len Brown
2007-06-20  3:49   ` Randy Dunlap
2007-06-20  3:51     ` Randy Dunlap
2007-06-20  4:41       ` Len Brown
2007-06-20  9:31       ` Andreas Herrmann
2007-06-20 14:28         ` Randy Dunlap
2007-06-20  8:49   ` Andreas Herrmann
2007-06-20 13:36     ` Len Brown
2007-06-20 13:46       ` Andi Kleen
2007-06-20 18:25       ` Ravikiran G Thirumalai
2007-06-21 18:36         ` Andreas Herrmann
2007-06-22 14:39           ` Andreas Herrmann
2007-06-23  3:55         ` Andrew Morton [this message]
2007-06-23  4:28           ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070622205530.964ebef9.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=ak@suse.de \
    --cc=andreas.herrmann3@amd.com \
    --cc=kiran@scalex86.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shai@scalex86.org \
    --cc=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox