Re: [RFC][PATCH -mm 0/9] PM: Update global suspend and hibernation operations framework

Rafael J. Wysocki
2007-07-02T14:21:20Z

On Monday, 2 July 2007 06:28, David Brownell wrote:
> On Saturday 30 June 2007, Rafael J. Wysocki wrote:
> >
> > The patches make the following changes:
> > * make ACPI use the new .set_target() method in 'struct pm_ops'
> > * add an ACPI helper function for the devices to determine the power state
> >   to put the device into
> > * move the definition of 'struct pm_ops' to <include/suspend.h>
> > * change the name of 'struct pm_ops' to 'struct platform_suspend_ops' and
> > modify the names of some related functions and global variables accordingly
> > * modify 'struct platform_suspend_ops' so that .prepare() and .finish() don't
> > take arguments (.enter() still takes the state argument, because some
> > platforms don't need to implement the other callbacks)
> > * make some functions normally defined in kernel/power/main.c be also defined
> > when CONFIG_PM is unset
> > * make suspend_ops be a static variable
> > * rework 'struct hibernation_ops' to add the new method analogous to
> >   .set_target()
> > * rename 'struct hibernation_ops' to 'struct platform_hibernation_ops' (in
> > analogy with 'struct platform_suspend_ops')
>
> These look like good cleanups and, in some cases, enhancements.

Thanks. :-)

Well, the patches 1/9 and 3/9-9/9 seem to be in a good shape (2/9 needs some
more work, perhaps I'll be able to do something about it later today), but I
have to wait with them for the Russell's ARM patchset to be merged. For now,
I'll just include them in the hibernation and suspend patchset
(http://www.sisk.pl/kernel/hibernation_and_suspend/2.6.22-rc7/patches/).

BTW, Russell, is there any chance that your patchest will be in -mm before
it's merged? My patches will go through -mm anyway ...

Greetings,
Rafael

--
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html