Re: [RFC][PATCH -mm 3/9] PM: Move definition of struct pm_ops to suspend.h

Pavel Machek
2007-06-30T23:04:14Z

On Sat 2007-06-30 23:01:55, Rafael J. Wysocki wrote:
> [Previous version of this was acked by Pavel, but I've updated it since then.]
> ---
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Move the definition of 'struct pm_ops' and related functions from <linux/pm.h>
> to <linux/suspend.h> .
>
> There are, at least, the following reasons to do that:
> * 'struct pm_ops' is specifically related to suspend and not to the power
> management in general.
> * As long as 'struct pm_ops' is defined in <linux/pm.h>, any modification of it
> causes the entire kernel to be recompiled, which is unnecessary and annoying.
> * Some suspend-related features are already defined in <linux/suspend.h>, so it
> is logical to move the definition of 'struct pm_ops' into there.
> * 'struct hibernation_ops', being the hibernation-related counterpart of
> 'struct pm_ops', is defined in <linux/suspend.h> .
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

ACK.

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html