From: Marcelo Tosatti <marcelo@kvack.org>
To: David Brownell <david-b@pacbell.net>
Cc: linux-pm@lists.linux-foundation.org, devel@laptop.org,
linux-acpi@vger.kernel.org
Subject: [PATCH] rtc-cmos: use cmos_rtc_board_info to determine wake_on callback
Date: Sat, 7 Jul 2007 23:49:53 -0400 [thread overview]
Message-ID: <20070708034953.GB19633@dmt> (raw)
In-Reply-To: <20070402165511.GD5024@cosmic.amd.com>
>From my understand ACPI fills a cmos_rtc_board_info with pointers for
wake_on/wake_off callbacks and registers that at dev->platform_data.
So use that to retrieve the callback pointers.
Am I missing something?
diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
index e24ea82..5bfab23 100644
--- a/drivers/rtc/rtc-cmos.c
+++ b/drivers/rtc/rtc-cmos.c
@@ -549,6 +549,7 @@ #ifdef CONFIG_PM
static int cmos_suspend(struct device *dev, pm_message_t mesg)
{
struct cmos_rtc *cmos = dev_get_drvdata(dev);
+ struct cmos_rtc_board_info *board_info = dev->platform_data;
int do_wake = device_may_wakeup(dev);
unsigned char tmp;
@@ -572,8 +573,8 @@ static int cmos_suspend(struct device *d
if (tmp & RTC_AIE) {
cmos->enabled_wake = 1;
- if (cmos->wake_on)
- cmos->wake_on(dev);
+ if (board_info->wake_on)
+ board_info->wake_on(dev);
else
enable_irq_wake(cmos->irq);
}
next prev parent reply other threads:[~2007-07-08 3:49 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 23:57 Power Mangement Interfaces Jordan Crouse
2007-03-31 0:18 ` Johannes Berg
2007-03-31 0:21 ` Johannes Berg
2007-03-31 4:33 ` [linux-pm] " Gopi P.M.
2007-03-31 15:20 ` Jordan Crouse
2007-03-31 16:12 ` David Brownell
2007-03-31 15:16 ` Jordan Crouse
2007-04-02 7:38 ` [linux-pm] " Pavel Machek
2007-03-31 16:57 ` David Brownell
2007-03-31 16:52 ` David Brownell
2007-03-31 18:16 ` Jordan Crouse
2007-03-31 18:57 ` David Brownell
2007-04-01 1:01 ` Jordan Crouse
2007-04-01 3:01 ` David Brownell
2007-04-01 16:56 ` Jordan Crouse
2007-04-02 0:28 ` David Brownell
2007-04-02 16:55 ` Jordan Crouse
2007-04-02 17:53 ` David Brownell
2007-07-08 3:46 ` rtc-cmos not supporting RTC_AIE? Marcelo Tosatti
2007-07-08 5:26 ` David Brownell
2007-07-08 19:03 ` Marcelo Tosatti
2007-07-08 19:17 ` David Brownell
2007-07-08 19:31 ` Richard Hughes
2007-07-08 20:15 ` Hibernate after alarm wakes from STR David Brownell
2007-07-08 22:31 ` Marcelo Tosatti
2007-07-09 2:44 ` David Brownell
2007-07-09 8:34 ` Richard Hughes
2007-07-09 15:40 ` Marcelo Tosatti
2007-07-09 16:26 ` David Brownell
2007-07-10 2:45 ` [linux-pm] " Nigel Cunningham
2007-07-10 16:51 ` David Brownell
2007-07-10 22:16 ` Nigel Cunningham
2007-07-11 0:45 ` Matthew Garrett
2007-07-11 0:53 ` Nigel Cunningham
2007-07-11 1:23 ` Matthew Garrett
2007-07-11 1:39 ` Nigel Cunningham
2007-07-11 1:59 ` Matthew Garrett
2007-07-11 3:14 ` Nigel Cunningham
2007-07-11 10:09 ` Rafael J. Wysocki
2007-07-11 10:14 ` Nigel Cunningham
2007-07-11 10:31 ` Rafael J. Wysocki
2007-07-11 16:04 ` David Brownell
2007-07-11 22:48 ` Nigel Cunningham
2007-07-08 3:49 ` Marcelo Tosatti [this message]
2007-07-08 5:06 ` [PATCH] rtc-cmos: use cmos_rtc_board_info to determine wake_on callback David Brownell
2007-07-08 3:55 ` [PATCH] OLPC rtc-cmos support Marcelo Tosatti
2007-07-08 5:13 ` David Brownell
2007-07-08 18:40 ` Marcelo Tosatti
2007-07-08 19:10 ` David Brownell
2007-07-08 20:17 ` Marcelo Tosatti
2007-07-08 20:47 ` David Brownell
2007-06-19 17:00 ` Power Mangement Interfaces Marcelo Tosatti
2007-06-19 19:17 ` Jens Axboe
2007-06-19 19:41 ` Woodruff, Richard
2007-06-21 1:30 ` David Brownell
2007-07-08 22:10 ` [PATCH] add powerbutton and lid platform devices Marcelo Tosatti
2007-07-09 15:05 ` Jordan Crouse
2007-07-09 16:30 ` David Brownell
2007-07-09 16:36 ` Jordan Crouse
2007-07-16 8:51 ` Richard Hughes
2007-07-16 17:11 ` C. Scott Ananian
2007-04-02 10:23 ` Power Mangement Interfaces Zhang Rui
2007-04-02 18:24 ` David Brownell
2007-04-02 19:40 ` Matthew Garrett
2007-04-02 21:31 ` David Brownell
2007-04-05 8:20 ` Zhang Rui
2007-04-02 10:07 ` Zhang Rui
2007-03-31 19:14 ` Jim Gettys
2007-04-02 9:36 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070708034953.GB19633@dmt \
--to=marcelo@kvack.org \
--cc=david-b@pacbell.net \
--cc=devel@laptop.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).