From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: lenb@kernel.org, ibm-acpi-devel@lists.sourceforge.net,
linux-acpi@vger.kernel.org, Richard Hughes <hughsient@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: ACPI: thinkpad-acpi: add input device support to hotkey subdriver
Date: Sat, 14 Jul 2007 23:31:45 +0100 [thread overview]
Message-ID: <20070714223144.GA25782@srcf.ucam.org> (raw)
In-Reply-To: <11844223334107-git-send-email-hmh@hmh.eng.br>
On Sat, Jul 14, 2007 at 11:11:59AM -0300, Henrique de Moraes Holschuh wrote:
> +static u16 hotkey_keycode_map[] = {
> + /* Scan Codes 0x00 to 0x0B: ACPI HKEY FN+F1..F12 */
> + KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN,
> + KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN,
> + KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN,
> + /* Scan codes 0x0C to 0x0F: Other ACPI HKEY hot keys */
> + KEY_UNKNOWN, /* 0x0C: FN+BACKSPACE */
> + KEY_UNKNOWN, /* 0x0D: FN+INSERT */
> + KEY_UNKNOWN, /* 0x0E: FN+DELETE */
> + KEY_RESERVED, /* 0x0F: FN+HOME (brightness up) */
KEY_BRIGHTNESSUP
> + /* Scan codes 0x10 to 0x1F: Extended ACPI HKEY hot keys */
> + KEY_RESERVED, /* 0x10: FN+END (brightness down) */
KEY_BRIGHTNESSDOWN
> + KEY_RESERVED, /* 0x11: FN+PGUP (thinklight toggle) */
> + KEY_UNKNOWN, /* 0x12: FN+PGDOWN */
> + KEY_ZOOM, /* 0x13: FN+SPACE (zoom) */
> + KEY_RESERVED, /* 0x14: VOLUME UP */
KEY_VOLUMEUP
> + KEY_RESERVED, /* 0x15: VOLUME DOWN */
KEY_VOLUMEDOWN
> + KEY_RESERVED, /* 0x16: MUTE */
KEY_MUTE
Why aren't we setting these sensibly?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2007-07-14 22:50 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-14 14:11 [GIT PULL] thinkpad-acpi queue for 2.6.23 (v2) Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: enable more hotkeys Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: update CMOS commands documentation Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad-acpi: make the input event mode the default Henrique de Moraes Holschuh
2007-07-14 22:33 ` Matthew Garrett
2007-07-15 18:05 ` Henrique de Moraes Holschuh
[not found] ` <20070715180529.GF14134-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-15 18:38 ` Matthew Garrett
2007-07-15 20:09 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2007-07-15 20:13 ` Matthew Garrett
2007-07-15 21:14 ` Henrique de Moraes Holschuh
[not found] ` <20070715211421.GG19066-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-15 21:19 ` Matthew Garrett
[not found] ` <20070715211953.GA6527-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2007-07-15 22:08 ` Henrique de Moraes Holschuh
[not found] ` <20070715220801.GK19066-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-15 22:49 ` Matthew Garrett
2007-07-16 0:12 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
[not found] ` <20070716001239.GA31604-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-16 0:24 ` Matthew Garrett
2007-07-16 3:02 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
[not found] ` <20070716030254.GD31604-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-16 15:27 ` Dmitry Torokhov
2007-07-16 18:21 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
[not found] ` <11844223322928-git-send-email-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
2007-07-14 14:11 ` ACPI: thinkpad-acpi: add DMI-based modalias Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: remove all uneeded initializers Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: update information on T43 thermal sensor 0xc1 Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: export hotkey maximum masks Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: export to sysfs the state of the radio slider switch Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: checkpoint sysfs interface version due to hotkey Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: register input device Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: add input device support to hotkey subdriver Henrique de Moraes Holschuh
2007-07-14 22:31 ` Matthew Garrett [this message]
[not found] ` <20070714223144.GA25782-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2007-07-15 18:12 ` Henrique de Moraes Holschuh
[not found] ` <20070715181233.GG14134-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-15 18:45 ` Matthew Garrett
[not found] ` <20070715184519.GD3235-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2007-07-15 20:03 ` Henrique de Moraes Holschuh
2007-07-15 20:12 ` [ibm-acpi-devel] " Matthew Garrett
2007-07-15 20:59 ` Henrique de Moraes Holschuh
2007-07-15 21:04 ` Matthew Garrett
2007-07-15 21:54 ` Henrique de Moraes Holschuh
[not found] ` <20070715215453.GJ19066-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-15 22:45 ` Matthew Garrett
2007-07-16 2:47 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2007-07-16 15:46 ` Dmitry Torokhov
2007-07-16 15:51 ` Matthew Garrett
2007-07-16 18:19 ` Henrique de Moraes Holschuh
2007-07-16 18:37 ` Matthew Garrett
2007-07-14 14:12 ` ACPI: thinkpad-acpi: add power-management handler capability Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad-acpi: export EV_SW SW_RADIO events Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad-acpi: checkpoint sysfs interface version due to input layer Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad-acpi: rename pci HID constant Henrique de Moraes Holschuh
2007-07-14 22:37 ` Matthew Garrett
[not found] ` <20070714223713.GC25782-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2007-07-15 18:02 ` Henrique de Moraes Holschuh
2007-07-15 18:34 ` Matthew Garrett
2007-07-15 21:18 ` Henrique de Moraes Holschuh
2007-07-15 21:23 ` Matthew Garrett
2007-07-14 14:12 ` pci-ids: add Lenovo PCI vendor ID Henrique de Moraes Holschuh
2007-07-15 11:52 ` Jeff Garzik
2007-07-15 21:22 ` Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad-acpi: store ThinkPad model information Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad-acpi: allow use of CMOS NVRAM for brightness control Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad-acpi: react to Lenovo ThinkPad differences in hot key Henrique de Moraes Holschuh
2007-07-14 22:39 ` Matthew Garrett
[not found] ` <20070714223932.GD25782-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2007-07-15 17:59 ` Henrique de Moraes Holschuh
2007-07-15 18:31 ` Matthew Garrett
[not found] ` <20070715183150.GA3235-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2007-07-15 20:17 ` Henrique de Moraes Holschuh
[not found] ` <20070715201712.GD19066-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-15 20:24 ` Matthew Garrett
2007-07-14 14:12 ` ACPI: thinkpad-acpi: make sure DSDT TMPx readings don't return +128 Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad-acpi: make EC-based thermal readings non-experimental Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad-acpi: bump up version to 0.15 Henrique de Moraes Holschuh
2007-07-14 14:58 ` [GIT PULL] thinkpad-acpi queue for 2.6.23 (v2) Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad_acpi: use bool for boolean parameters Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070714223144.GA25782@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=hughsient@gmail.com \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox