Re: ACPI: thinkpad-acpi: react to Lenovo ThinkPad differences in hot key

Henrique de Moraes Holschuh
2007-07-15T17:59:22Z

Hi Matthew!

On Sat, 14 Jul 2007, Matthew Garrett wrote:

> On Sat, Jul 14, 2007 at 11:12:09AM -0300, Henrique de Moraes Holschuh wrote:
>
> Ah, I see this one fixes some of my comments. However:
>
> > + KEY_RESERVED, /* 0x0F: FN+HOME (brightness up) */
> > + /* Scan codes 0x10 to 0x1F: Extended ACPI HKEY hot keys */
> > + KEY_RESERVED, /* 0x10: FN+END (brightness down) */
>
> > + KEY_BRIGHTNESSUP, /* 0x0F: FN+HOME (brightness up) */
> > + /* Scan codes 0x10 to 0x1F: Extended ACPI HKEY hot keys */
> > + KEY_BRIGHTNESSDOWN, /* 0x10: FN+END (brightness down) */
>
> Why this difference?

Brightness events are handled in firmware (and no, you cannot make the
firmware NOT handle it) in IBM thinkpads. Lenovo thinkpads seem to be
moving it to userspace, so you have to generate the events and actively
handle them in the ACPI OSI or in userspace.

I generate events *only* for stuff that needs active handling by default.
Since the hotkey mask cannot really be trusted to filter out events (unless
I start filtering it in the driver *as well*... might be a good idea), I
don't add the passive keys to the keymap.

Regardless, userspace *will* have to take some action to enable the hotkeys
that are to only be used for passive monitoring. Right now this means
enabling them in the mask, and remapping the key map. If this is that a big
problem, I can add extra driver filtering, and make it only "enable it in
the mask".

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh