Re: ACPI: thinkpad-acpi: make the input event mode the default

Henrique de Moraes Holschuh
2007-07-15T22:08:01Z

On Sun, 15 Jul 2007, Matthew Garrett wrote:
> On Sun, Jul 15, 2007 at 06:14:21PM -0300, Henrique de Moraes Holschuh wrote:
> > On Sun, 15 Jul 2007, Matthew Garrett wrote:
> > > We already have in-kernel drivers that do this properly, so I'd suspect
> > > that whoever told you that was wrong.
> >
> > I got tired of being told one way or the other, already.
> >
> > My position is simple, for now: I am keeping model-specific knowledge on the
> > driver to the bare minimum needed for correct driver operation. But I will
> > add it anytime I fell it is needed to keep correct driver operation.
>
> Right now, the hotkey functionality of the driver is not terribly useful
> without (bleeding-edge) userspace. This is inconsistent with the
> majority of input drivers which do something broadly sane in that
> situation.

It works better with non-bleeding-edge userspace the way I did it, as far as
I know. So I'll need some explanations about what I should be doing
differently.

Here's my view on things:

Non-bleeding-edge userspace screws up volume control if I send events. And
so does bleeding-edge userspace for that matter, AFAIK.

Non-bleeding-edge userspace screws up brightness control if I send events.
Bleeding-edge userspace needs to be told it exists, anyway, to make proper
use of it, and can be told to enable it on the driver while at it.

Non-bleeding-edge userspace that is not broken can remap keys already.
FN+F1 generating KEY_FN_F1 makes a lot more sense to someone which has a
blank FN+F1 key, than it generating "KEY_FOOBAR".

So exactly what should I be changing to make it more useful? WHAT hot keys
do you want mapped by default, and to which key codes? And forget the ones
that need passive handling, these are not mapped for a very different
reason.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh