Re: ACPI: thinkpad-acpi: rename pci HID constant

Matthew Garrett
2007-07-15T18:49:59Z

On Sun, Jul 15, 2007 at 03:02:46PM -0300, Henrique de Moraes Holschuh wrote:
> On Sat, 14 Jul 2007, Matthew Garrett wrote:
> > On Sat, Jul 14, 2007 at 11:12:04AM -0300, Henrique de Moraes Holschuh wrote:
> > > - .hid = IBM_PCI_HID,
> > > + /* THIS ONE MUST NEVER BE USED FOR DRIVER AUTOLOADING.
> >
> > Some rationale here would be good. There are no known devices where
> > loading ibm-acpi is harmful.
>
> It is completely and utterly useless to autoload based on this. You would
> try to autoload it on every machine with a PCI root bridge, which is NOT a
> bright idea at all.

I meant the IBM0068 device. That doesn't appear to be used anywhere
other than Thinkpads.
--
Matthew Garrett | mjg59@srcf.ucam.org