Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: add input device support to hotkey subdriver

Matthew Garrett
2007-07-15T21:04:17Z

On Sun, Jul 15, 2007 at 05:59:34PM -0300, Henrique de Moraes Holschuh wrote:

> *HAL* does. HAL is *not* all there is to userspace. The input layer is not
> an interface between the kernel and HAL, it is an interface between kernel
> and userspace.

Hal is the only piece of userspace that knows how to speak to more than
one type of backlight in any useful way, which makes it the de-facto
reference for how userspace interprets these keys.

> Add that knowledge to the input layer, and I will agree. Add it to every
> consumer of input events, and I will concede. Until then, it is good that
> HAL can overcome the lack of such information in the input layer, but that
> doesn't make it the right way to use the input layer.

The fact that keys share event codes doesn't mean that these keycodes
are going to have identical semantics on all hardware. One solution to
that would be to avoid ever sending these keycodes, but that would make
having them defined in the first place a bit silly. Since they /are/
there, it makes sense to use them.

--
Matthew Garrett | mjg59@srcf.ucam.org