Re: ACPI: thinkpad-acpi: react to Lenovo ThinkPad differences in hot key

Matthew Garrett
2007-07-15T18:44:44Z

On Sun, Jul 15, 2007 at 02:59:22PM -0300, Henrique de Moraes Holschuh wrote:
> On Sat, 14 Jul 2007, Matthew Garrett wrote:
>
> > On Sat, Jul 14, 2007 at 11:12:09AM -0300, Henrique de Moraes Holschuh wrote:
> >
> > Ah, I see this one fixes some of my comments. However:
> >
> > > + KEY_RESERVED, /* 0x0F: FN+HOME (brightness up) */
> > > + /* Scan codes 0x10 to 0x1F: Extended ACPI HKEY hot keys */
> > > + KEY_RESERVED, /* 0x10: FN+END (brightness down) */
> >
> > > + KEY_BRIGHTNESSUP, /* 0x0F: FN+HOME (brightness up) */
> > > + /* Scan codes 0x10 to 0x1F: Extended ACPI HKEY hot keys */
> > > + KEY_BRIGHTNESSDOWN, /* 0x10: FN+END (brightness down) */
> >
> > Why this difference?
>
> Brightness events are handled in firmware (and no, you cannot make the
> firmware NOT handle it) in IBM thinkpads. Lenovo thinkpads seem to be
> moving it to userspace, so you have to generate the events and actively
> handle them in the ACPI OSI or in userspace.

I believe that this is dependent on the BIOS version, not whether the
distinction is Lenovo/IBM.

> Regardless, userspace *will* have to take some action to enable the hotkeys
> that are to only be used for passive monitoring. Right now this means
> enabling them in the mask, and remapping the key map. If this is that a big
> problem, I can add extra driver filtering, and make it only "enable it in
> the mask".

HAL already has a flag indicating whether applications should respond to
brightness keys actively or passively. Life would be significantly
easier if they're mapped by default, since the alternative is that
everyone will just map them anyway.

--
Matthew Garrett | mjg59@srcf.ucam.org