From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Jeff Garzik <jeff@garzik.org>
Cc: lenb@kernel.org, ibm-acpi-devel@lists.sourceforge.net,
linux-acpi@vger.kernel.org
Subject: Re: pci-ids: add Lenovo PCI vendor ID
Date: Sun, 15 Jul 2007 18:22:06 -0300 [thread overview]
Message-ID: <20070715212206.GI19066@khazad-dum.debian.net> (raw)
In-Reply-To: <469A0A6A.9020208@garzik.org>
On Sun, 15 Jul 2007, Jeff Garzik wrote:
> Henrique de Moraes Holschuh wrote:
>> thinkpad-acpi wants to differentiate IBM from Lenovo ThinkPads, and the
>> PCI
>> IDs are the best way to go about it for quirk tables and so on. Add the
>> missing Lenovo PCI ID to pci_ids.h.
>> Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
>> Cc: Jeff Garzik <jeff@garzik.org>
>> ---
>> include/linux/pci_ids.h | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index 5b1c999..b5f54ca 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -2067,6 +2067,8 @@
>> #define PCI_DEVICE_ID_ALTIMA_AC9100 0x03ea
>> #define PCI_DEVICE_ID_ALTIMA_AC1003 0x03eb
>> +#define PCI_VENDOR_ID_LENOVO 0x17aa
>> +
>> #define PCI_VENDOR_ID_ARECA 0x17d3
>> #define PCI_DEVICE_ID_ARECA_1110 0x1110
>
> Not sure why I'm CC'd :) But of course I have an opinion :) Usually we
> don't add these IDs until a driver is actually using them. Just add it in
> the patch that starts using it in thinkpad-acpi.
Very well. I don't usually merge stuff that goes to different subsystems,
but since you implicitly ACK'd it... :-)
I will merge this patch with the next one in the series :)
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2007-07-15 21:22 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-14 14:11 [GIT PULL] thinkpad-acpi queue for 2.6.23 (v2) Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: enable more hotkeys Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: update CMOS commands documentation Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad-acpi: make the input event mode the default Henrique de Moraes Holschuh
2007-07-14 22:33 ` Matthew Garrett
2007-07-15 18:05 ` Henrique de Moraes Holschuh
[not found] ` <20070715180529.GF14134-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-15 18:38 ` Matthew Garrett
2007-07-15 20:09 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2007-07-15 20:13 ` Matthew Garrett
2007-07-15 21:14 ` Henrique de Moraes Holschuh
[not found] ` <20070715211421.GG19066-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-15 21:19 ` Matthew Garrett
[not found] ` <20070715211953.GA6527-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2007-07-15 22:08 ` Henrique de Moraes Holschuh
[not found] ` <20070715220801.GK19066-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-15 22:49 ` Matthew Garrett
2007-07-16 0:12 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
[not found] ` <20070716001239.GA31604-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-16 0:24 ` Matthew Garrett
2007-07-16 3:02 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
[not found] ` <20070716030254.GD31604-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-16 15:27 ` Dmitry Torokhov
2007-07-16 18:21 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad_acpi: use bool for boolean parameters Henrique de Moraes Holschuh
[not found] ` <11844223322928-git-send-email-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
2007-07-14 14:11 ` ACPI: thinkpad-acpi: add DMI-based modalias Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: remove all uneeded initializers Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: update information on T43 thermal sensor 0xc1 Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: export hotkey maximum masks Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: export to sysfs the state of the radio slider switch Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: checkpoint sysfs interface version due to hotkey Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: register input device Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: add input device support to hotkey subdriver Henrique de Moraes Holschuh
2007-07-14 22:31 ` Matthew Garrett
[not found] ` <20070714223144.GA25782-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2007-07-15 18:12 ` Henrique de Moraes Holschuh
[not found] ` <20070715181233.GG14134-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-15 18:45 ` Matthew Garrett
[not found] ` <20070715184519.GD3235-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2007-07-15 20:03 ` Henrique de Moraes Holschuh
2007-07-15 20:12 ` [ibm-acpi-devel] " Matthew Garrett
2007-07-15 20:59 ` Henrique de Moraes Holschuh
2007-07-15 21:04 ` Matthew Garrett
2007-07-15 21:54 ` Henrique de Moraes Holschuh
[not found] ` <20070715215453.GJ19066-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-15 22:45 ` Matthew Garrett
2007-07-16 2:47 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2007-07-16 15:46 ` Dmitry Torokhov
2007-07-16 15:51 ` Matthew Garrett
2007-07-16 18:19 ` Henrique de Moraes Holschuh
2007-07-16 18:37 ` Matthew Garrett
2007-07-14 14:12 ` ACPI: thinkpad-acpi: add power-management handler capability Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad-acpi: export EV_SW SW_RADIO events Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad-acpi: checkpoint sysfs interface version due to input layer Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad-acpi: rename pci HID constant Henrique de Moraes Holschuh
2007-07-14 22:37 ` Matthew Garrett
[not found] ` <20070714223713.GC25782-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2007-07-15 18:02 ` Henrique de Moraes Holschuh
2007-07-15 18:34 ` Matthew Garrett
2007-07-15 21:18 ` Henrique de Moraes Holschuh
2007-07-15 21:23 ` Matthew Garrett
2007-07-14 14:12 ` pci-ids: add Lenovo PCI vendor ID Henrique de Moraes Holschuh
2007-07-15 11:52 ` Jeff Garzik
2007-07-15 21:22 ` Henrique de Moraes Holschuh [this message]
2007-07-14 14:12 ` ACPI: thinkpad-acpi: store ThinkPad model information Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad-acpi: allow use of CMOS NVRAM for brightness control Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad-acpi: react to Lenovo ThinkPad differences in hot key Henrique de Moraes Holschuh
2007-07-14 22:39 ` Matthew Garrett
[not found] ` <20070714223932.GD25782-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2007-07-15 17:59 ` Henrique de Moraes Holschuh
2007-07-15 18:31 ` Matthew Garrett
[not found] ` <20070715183150.GA3235-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2007-07-15 20:17 ` Henrique de Moraes Holschuh
[not found] ` <20070715201712.GD19066-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-15 20:24 ` Matthew Garrett
2007-07-14 14:12 ` ACPI: thinkpad-acpi: make sure DSDT TMPx readings don't return +128 Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad-acpi: make EC-based thermal readings non-experimental Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad-acpi: bump up version to 0.15 Henrique de Moraes Holschuh
2007-07-14 14:58 ` [GIT PULL] thinkpad-acpi queue for 2.6.23 (v2) Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070715212206.GI19066@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=jeff@garzik.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox