Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

Henrique de Moraes Holschuh
2007-07-15T21:14:29Z

On Sun, 15 Jul 2007, Matthew Garrett wrote:
> On Sun, Jul 15, 2007 at 05:09:48PM -0300, Henrique de Moraes Holschuh wrote:
> > On Sun, 15 Jul 2007, Matthew Garrett wrote:
> > > But we're able to differentiate between the models.
> >
> > Yes. And I was told to not do it in the kernel when possible, so I will map
> > by default only what is marked and working on a vast majority. Otherwise,
> > I'd need a big quirk db, based on what is silk-screened on the keyboards.
>
> We already have in-kernel drivers that do this properly, so I'd suspect
> that whoever told you that was wrong.

I got tired of being told one way or the other, already.

My position is simple, for now: I am keeping model-specific knowledge on the
driver to the bare minimum needed for correct driver operation. But I will
add it anytime I fell it is needed to keep correct driver operation.

The different lenovo/ibm keymaps were added because of the mess with the
brightness and volume keys in the latest BIOSes.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh