Re: ACPI: thinkpad-acpi: add input device support to hotkey subdriver

Matthew Garrett
2007-07-14T22:50:45Z

On Sat, Jul 14, 2007 at 11:11:59AM -0300, Henrique de Moraes Holschuh wrote:

> +static u16 hotkey_keycode_map[] = {
> + /* Scan Codes 0x00 to 0x0B: ACPI HKEY FN+F1..F12 */
> + KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN,
> + KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN,
> + KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN,
> + /* Scan codes 0x0C to 0x0F: Other ACPI HKEY hot keys */
> + KEY_UNKNOWN, /* 0x0C: FN+BACKSPACE */
> + KEY_UNKNOWN, /* 0x0D: FN+INSERT */
> + KEY_UNKNOWN, /* 0x0E: FN+DELETE */
> + KEY_RESERVED, /* 0x0F: FN+HOME (brightness up) */

KEY_BRIGHTNESSUP

> + /* Scan codes 0x10 to 0x1F: Extended ACPI HKEY hot keys */
> + KEY_RESERVED, /* 0x10: FN+END (brightness down) */

KEY_BRIGHTNESSDOWN

> + KEY_RESERVED, /* 0x11: FN+PGUP (thinklight toggle) */
> + KEY_UNKNOWN, /* 0x12: FN+PGDOWN */
> + KEY_ZOOM, /* 0x13: FN+SPACE (zoom) */
> + KEY_RESERVED, /* 0x14: VOLUME UP */

KEY_VOLUMEUP

> + KEY_RESERVED, /* 0x15: VOLUME DOWN */

KEY_VOLUMEDOWN

> + KEY_RESERVED, /* 0x16: MUTE */

KEY_MUTE

Why aren't we setting these sensibly?

--
Matthew Garrett | mjg59@srcf.ucam.org