From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH 5/7] Make the driver use MSC_SCAN and a setkeycode and getkeycode key table. Date: Mon, 16 Jul 2007 19:09:28 +0100 Message-ID: <20070716180928.GA21211@srcf.ucam.org> References: <1184520879452-git-send-email-malattia@linux.it> <1184520879991-git-send-email-malattia@linux.it> <11845208793336-git-send-email-malattia@linux.it> <11845208793678-git-send-email-malattia@linux.it> <11845208794064-git-send-email-malattia@linux.it> <11845208791511-git-send-email-malattia@linux.it> <20070715211128.GA6291@srcf.ucam.org> <1184605565.2228.57.camel@work> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([217.147.92.49]:56962 "EHLO vavatch.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751538AbXGPSJj (ORCPT ); Mon, 16 Jul 2007 14:09:39 -0400 Content-Disposition: inline In-Reply-To: <1184605565.2228.57.camel@work> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Richard Hughes Cc: Mattia Dongili , Len Brown , linux-acpi@vger.kernel.org, Stelian Pop , Richard Hughes , Dmitry Torokhov On Mon, Jul 16, 2007 at 06:06:05PM +0100, Richard Hughes wrote: > On Sun, 2007-07-15 at 22:11 +0100, Matthew Garrett wrote: > > On Mon, Jul 16, 2007 at 02:34:37AM +0900, Mattia Dongili wrote: > > > + /* we emit the scancode so we can always remap the key */ > > > + input_event(kp.dev, EV_MSC, MSC_SCAN, event); > > > > As I said to Henrique, I don't think this is the right solution. We know > > what these keys do - we should send the appropriate keycode, rather than > > asking userspace to remap it. > > We don't - the decal on FnF2 changes between different models, and I'm > sure others are the same. That's fine, we have information that lets us distinguish between models. -- Matthew Garrett | mjg59@srcf.ucam.org