Re: ACPI: thinkpad-acpi: rename pci HID constant

Henrique de Moraes Holschuh
2007-07-15T21:18:26Z

On Sun, 15 Jul 2007, Matthew Garrett wrote:
> On Sun, Jul 15, 2007 at 03:02:46PM -0300, Henrique de Moraes Holschuh wrote:
> > On Sat, 14 Jul 2007, Matthew Garrett wrote:
> > > On Sat, Jul 14, 2007 at 11:12:04AM -0300, Henrique de Moraes Holschuh wrote:
> > > > - .hid = IBM_PCI_HID,
> > > > + /* THIS ONE MUST NEVER BE USED FOR DRIVER AUTOLOADING.
> > >
> > > Some rationale here would be good. There are no known devices where
> > > loading ibm-acpi is harmful.
> >
> > It is completely and utterly useless to autoload based on this. You would
> > try to autoload it on every machine with a PCI root bridge, which is NOT a
> > bright idea at all.
>
> I meant the IBM0068 device. That doesn't appear to be used anywhere
> other than Thinkpads.

Oh, you CAN use the IBM0068 device to autoload. I am not really sure
nothing but ThinkPads use it, and I already have other autoload hooks (based
on DMI) anyway, but it can be used as an autoload hint, yes.

But the comment about not using a HID for driver autoloading is for the
PCI_ROOT_HID_STRING only. Is it in a confusing place on the source code, or
somesuch?

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh