Re: ACPI: thinkpad-acpi: rename pci HID constant

Henrique de Moraes Holschuh
2007-07-15T18:02:46Z

On Sat, 14 Jul 2007, Matthew Garrett wrote:
> On Sat, Jul 14, 2007 at 11:12:04AM -0300, Henrique de Moraes Holschuh wrote:
> > - .hid = IBM_PCI_HID,
> > + /* THIS ONE MUST NEVER BE USED FOR DRIVER AUTOLOADING.
>
> Some rationale here would be good. There are no known devices where
> loading ibm-acpi is harmful.

It is completely and utterly useless to autoload based on this. You would
try to autoload it on every machine with a PCI root bridge, which is NOT a
bright idea at all.

Not to mention thinkpad-acpi uses this only on a extremely old model 570,
AFAIK.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh