* acpi_bus_generate_genetlink_event
@ 2007-07-19 20:25 Andrew Morton
2007-07-20 5:29 ` acpi_bus_generate_genetlink_event Zhang Rui
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Morton @ 2007-07-19 20:25 UTC (permalink / raw)
To: Zhang Rui; +Cc: linux-acpi
It's quite sad that this uses GFP_ATOMIC. Because GFP_ATOMIC is quite
unreliable.
Is it just not possible to use GFP_KERNEL here?
If _any_ of the callers of this function could have used GFP_KERNEL then we
could at least pass the gfp_t into this function to allow it to use the
stronger form where it can do so.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: acpi_bus_generate_genetlink_event
2007-07-19 20:25 acpi_bus_generate_genetlink_event Andrew Morton
@ 2007-07-20 5:29 ` Zhang Rui
0 siblings, 0 replies; 2+ messages in thread
From: Zhang Rui @ 2007-07-20 5:29 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-acpi
On Fri, 2007-07-20 at 04:25 +0800, Andrew Morton wrote:
>
> It's quite sad that this uses GFP_ATOMIC. Because GFP_ATOMIC is quite
> unreliable.
>
> Is it just not possible to use GFP_KERNEL here?
I thought of this problem before,
but GFP_ATOMIC is required in some cases.
> If _any_ of the callers of this function could have used GFP_KERNEL
> then we
> could at least pass the gfp_t into this function to allow it to use
> the
> stronger form where it can do so.
>
That makes sense. I'll send an incremental patch soon.
Thanks,
Rui
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-20 5:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-19 20:25 acpi_bus_generate_genetlink_event Andrew Morton
2007-07-20 5:29 ` acpi_bus_generate_genetlink_event Zhang Rui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox