From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Richard Hughes <hughsient@gmail.com>,
trenn@suse.de, Len Brown <lenb@kernel.org>,
Dmitry Torokhov <dtor@insightbb.com>,
linux-acpi <linux-acpi@vger.kernel.org>,
linux-input <linux-input@atrey.karlin.mff.cuni.cz>,
Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [patch] Refresh lid state on resume
Date: Tue, 31 Jul 2007 09:53:50 -0300 [thread overview]
Message-ID: <20070731125350.GC19965@khazad-dum.debian.net> (raw)
In-Reply-To: <200707311108.42947.rjw@sisk.pl>
On Tue, 31 Jul 2007, Rafael J. Wysocki wrote:
> > I guess it's up to the BIOS, and I don't think this refresh hurts any
> > machines that implement a notify on resume, and fixes a fair few
> > machines that don't.
>
> AFAICS, the notify doesn't seem to work very well on some machines.
I have noticed thinkpad-acpi gets notifications during *early resume*
sometimes, and certainly *well* before its own resume handlers are called.
That might be part of the problem.
> Are there any downsides of the $subject patch?
None that I know. I am doing something like that in thinkpad-acpi for
input-layer switches, and it helps a great deal.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
prev parent reply other threads:[~2007-07-31 12:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 11:15 [patch] Refresh lid state on resume Richard Hughes
2007-07-30 15:21 ` Thomas Renninger
2007-07-30 15:33 ` Richard Hughes
2007-07-31 9:08 ` Rafael J. Wysocki
2007-07-31 9:07 ` Richard Hughes
2007-07-31 10:42 ` Thomas Renninger
2007-07-31 13:18 ` Richard Hughes
2007-07-31 13:42 ` Rafael J. Wysocki
2007-07-31 14:26 ` [PATCH] Enable GPEs before _WAK is called Thomas Renninger
2007-07-31 15:09 ` Rafael J. Wysocki
2007-07-31 12:53 ` Henrique de Moraes Holschuh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070731125350.GC19965@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=dtor@insightbb.com \
--cc=hughsient@gmail.com \
--cc=kay.sievers@vrfy.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=rjw@sisk.pl \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox