From: Len Brown <lenb@kernel.org>
To: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] ACPI: add "Fujitsu laptop extras" module
Date: Fri, 24 Aug 2007 00:23:08 -0400 [thread overview]
Message-ID: <200708240023.08757.lenb@kernel.org> (raw)
In-Reply-To: <200708240315.l7O3FMCI030158@turbo.physics.adelaide.edu.au>
On Thursday 23 August 2007 23:15, Jonathan Woithe wrote:
> > Oh, i forgot to mention also...
> > There should be no new files created under /proc/acpi
> > for platform specific drivers.
>
> Sure. In the case of the backlight control (which is the thing I most care
> about) this will be taken care of by virue of utilising the backlight class
> as per Matthew's email. If it did prove useful to export the mouse pointer
> control for example (which at this stage is uncertain) what would be the
> most appropriate location for the associated virtual files - something under
> /sys?
yes, certainly something outside of /proc.
ideally something _generic_ under /sys.
If device specific and the device exists in sysfs already, then there.
But there can be platform specific hooks in sysfs too.
thinkpad-acpi stuffs some platform specific junk under /sys/devices/platform/
see Documentation/thinkpad-acpi.txt
your fujitsu driver will probably be a lot like the msi-laptop.c driver
when you're done with it, maybe even simpler.
cheers,
-Len
next prev parent reply other threads:[~2007-08-24 4:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-24 0:42 [PATCH] ACPI: add "Fujitsu laptop extras" module Jonathan Woithe
2007-08-24 1:32 ` Matthew Garrett
2007-08-24 1:51 ` Jonathan Woithe
2007-08-24 2:33 ` Matthew Garrett
2007-08-24 2:13 ` Len Brown
2007-08-24 3:11 ` Len Brown
2007-08-24 3:15 ` Jonathan Woithe
2007-08-24 4:23 ` Len Brown [this message]
2007-08-27 3:21 ` [PATCH] ACPI: add "Fujitsu laptop extras" module, take 2 Jonathan Woithe
2007-08-24 3:12 ` [PATCH] ACPI: add "Fujitsu laptop extras" module Jonathan Woithe
2007-08-24 3:55 ` Zhang Rui
2007-08-24 4:12 ` Matthew Garrett
2007-08-25 6:05 ` Len Brown
2007-08-24 7:24 ` Adrian Yee
2007-08-24 7:31 ` Jonathan Woithe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708240023.08757.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=jwoithe@physics.adelaide.edu.au \
--cc=linux-acpi@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).