* [PATCH] ACPI: Clean up acpi_enter_sleep_state_prep
@ 2007-08-22 9:56 Rafael J. Wysocki
2007-08-24 8:13 ` Pavel Machek
0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2007-08-22 9:56 UTC (permalink / raw)
To: Andrew Morton
Cc: ACPI Devel Maling List, Len Brown, LKML, Pavel Machek, pm list
From: Rafael J. Wysocki <rjw@sisk.pl>
Remove some redundant code from acpi_enter_sleep_state_prep() and clean up
a comment in there.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/acpi/hardware/hwsleep.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
Index: linux-2.6.23-rc3/drivers/acpi/hardware/hwsleep.c
===================================================================
--- linux-2.6.23-rc3.orig/drivers/acpi/hardware/hwsleep.c 2007-08-22 11:40:30.000000000 +0200
+++ linux-2.6.23-rc3/drivers/acpi/hardware/hwsleep.c 2007-08-22 11:40:53.000000000 +0200
@@ -234,15 +234,11 @@ acpi_status acpi_enter_sleep_state_prep(
"While executing method _SST"));
}
- /*
- * 1) Disable/Clear all GPEs
- */
+ /* Disable/Clear all GPEs */
+
status = acpi_hw_disable_all_gpes();
- if (ACPI_FAILURE(status)) {
- return_ACPI_STATUS(status);
- }
- return_ACPI_STATUS(AE_OK);
+ return_ACPI_STATUS(status);
}
ACPI_EXPORT_SYMBOL(acpi_enter_sleep_state_prep)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPI: Clean up acpi_enter_sleep_state_prep
2007-08-22 9:56 [PATCH] ACPI: Clean up acpi_enter_sleep_state_prep Rafael J. Wysocki
@ 2007-08-24 8:13 ` Pavel Machek
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2007-08-24 8:13 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Andrew Morton, ACPI Devel Maling List, Len Brown, LKML, pm list
On Wed 2007-08-22 11:56:35, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Remove some redundant code from acpi_enter_sleep_state_prep() and clean up
> a comment in there.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
ACK.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-24 21:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-22 9:56 [PATCH] ACPI: Clean up acpi_enter_sleep_state_prep Rafael J. Wysocki
2007-08-24 8:13 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).