Re: ACPI video extensions - ACPI vendor specific drivers vs. video module

[Matthew Garrett <mjg59@srcf.ucam.org>]

On Fri, Aug 24, 2007 at 02:10:23PM +0200, Thomas Renninger wrote:
> On Fri, 2007-08-24 at 12:48 +0100, Matthew Garrett wrote:
> > I'm not sure there's any especially compelling reason. As long as the 
> > platform-specific interfaces still work, there's no reason to prefer the 
> > ACPI interfaces.
> 
> There are some reasons:
>   - If the platform-specific interfaces do not work anymore, it's
>     already too late. E.g. we see this now for 10.3 with the ThinkPad
>     driver.

The driver shouldn't expose functionality that doesn't work.

>   - Code cleanup: It would be great to rip out some duplicate code.
>     Especially the code size growth of the ThinkPad module which now
>     exceeds the 4000 line mark makes me a bit worry how this should
>     stay maintainable (imagine Henrique not doing all the good work
>     there anymore...).

It's not code duplication. Old Thinkpads (and we're talking 2004 here, 
not amazingly old) don't implement the backlight control section of the 
video spec, so removing the functionality from thinkpad-acpi would be a 
regression.

-- 
Matthew Garrett | mjg59@srcf.ucam.org