Re: [PATCH] ACPI: add "Fujitsu laptop extras" module, take 3

[Len Brown <lenb@kernel.org>]

> +static int __init fujitsu_init(void)
> +{
> +	int ret, result;
> +
> +	if (acpi_disabled)
> +		return -ENODEV;
> +
> +	fujitsu = kmalloc(sizeof(struct fujitsu_t), GFP_KERNEL);
> +	if (!fujitsu)
> +		return -ENOMEM;
> +	memset(fujitsu, 0, sizeof(struct fujitsu_t));
> +
> +	result = acpi_bus_register_driver(&acpi_fujitsu_driver);
> +	if (result < 0) {
> +		goto fail_acpi;
> +	}

if this goto is taken, then "ret" is used uninitialized below:

> +      fail_acpi:
> +
> +	kfree(fujitsu);
> +
> +	return ret;
> +}