linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maik Broemme <mbroemme@plusserver.de>
To: linux-acpi@vger.kernel.org
Subject: [PATCH] Removing of useless printk in drivers/acpi/video.c
Date: Fri, 14 Sep 2007 22:12:34 +0200	[thread overview]
Message-ID: <20070914201234.GT6339@bart.intergenia.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

Hi,

i am actually heavily using the ACPI video extension for my Thinkpad X61
Tablet. I have bound the input events triggered by the brightness
up/down keys to a simple

echo <value> > /sys/class/backlight/acpi_video1/brightness

but everytime the event is triggered and acpi_video_device_lcd_set_level()
is called i got a notificication in my kernel log like:

set_level status: 0
set_level status: 0
set_level status: 0
set_level status: 0
...

I have attached a patch to remove this one printk() i really don't know
why it is needed. :)

--Maik

[-- Attachment #2: linux-2.6.23-rc6-acpi-video-fix.patch --]
[-- Type: text/plain, Size: 476 bytes --]

diff -Nur linux-2.6.23-rc6-acpi-video-fix/drivers/acpi/video.c linux-2.6.23-rc6/drivers/acpi/video.c
--- linux-2.6.23-rc6-acpi-video-fix/drivers/acpi/video.c	2007-09-11 04:50:29.000000000 +0200
+++ linux-2.6.23-rc6/drivers/acpi/video.c	2007-09-14 22:06:21.000000000 +0200
@@ -417,7 +417,6 @@
 	arg0.integer.value = level;
 	status = acpi_evaluate_object(device->dev->handle, "_BCM", &args, NULL);
 
-	printk(KERN_DEBUG "set_level status: %x\n", status);
 	return status;
 }
 

             reply	other threads:[~2007-09-14 21:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-14 20:12 Maik Broemme [this message]
2007-09-18 17:43 ` [PATCH] Removing of useless printk in drivers/acpi/video.c Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070914201234.GT6339@bart.intergenia.de \
    --to=mbroemme@plusserver.de \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).