From: Andreas Herrmann <aherrman@arcor.de>
To: Len Brown <len.brown@intel.com>
Cc: Mattia Dongili <malattia@linux.it>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
linux-acpi@vger.kernel.org
Subject: [PATCH] sony-laptop/thinkpad-acpi: fix build error
Date: Mon, 17 Sep 2007 22:54:34 +0200 [thread overview]
Message-ID: <20070917205434.GA22458@devil> (raw)
sony-laptop and thinkpad-acpi make use of input-core functions.
Hence you get link errors if those drivers are built but CONFIG_INPUT
is not set. Attached patch fixes this minor issue.
Regards,
Andreas
--
Build errors if CONFIG_SONY_LAPTOP && !INPUT or
if CONFIG_THINKPAD_ACPI && !INPUT:
LD vmlinux
...
drivers/built-in.o: In function `sony_laptop_remove_input':
sony-laptop.c:(.text+0x768fb): undefined reference to `input_unregister_device'
...
drivers/built-in.o: In function `thinkpad_acpi_module_exit':
thinkpad_acpi.c:(.text+0x78c1b): undefined reference to `input_free_device'
...
I suggest to auto-select CONFIG_INPUT for both drivers.
Signed-off-by: Andreas Herrmann <aherrman@arcor.de>
---
drivers/misc/Kconfig | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 73e248f..c077df8 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -134,6 +134,7 @@ config SONY_LAPTOP
tristate "Sony Laptop Extras"
depends on X86 && ACPI
select BACKLIGHT_CLASS_DEVICE
+ select INPUT
---help---
This mini-driver drives the SNC and SPIC devices present in the ACPI
BIOS of the Sony Vaio laptops.
@@ -156,6 +157,7 @@ config THINKPAD_ACPI
select BACKLIGHT_CLASS_DEVICE
select HWMON
select NVRAM
+ select INPUT
---help---
This is a driver for the IBM and Lenovo ThinkPad laptops. It adds
support for Fn-Fx key combinations, Bluetooth control, video
--
1.5.3
next reply other threads:[~2007-09-17 20:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 20:54 Andreas Herrmann [this message]
2007-09-18 4:01 ` [PATCH] sony-laptop/thinkpad-acpi: fix build error Henrique de Moraes Holschuh
2007-09-18 11:03 ` Mattia Dongili
2007-09-18 16:49 ` Len Brown
2007-09-18 19:23 ` Henrique de Moraes Holschuh
2007-09-18 19:53 ` aherrman
2007-09-18 23:04 ` Mattia Dongili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070917205434.GA22458@devil \
--to=aherrman@arcor.de \
--cc=hmh@hmh.eng.br \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=malattia@linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).