* [PATCH] acpi_video: kernel build error if !INPUT
@ 2007-09-17 21:41 Andreas Herrmann
2007-09-18 16:53 ` Len Brown
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Herrmann @ 2007-09-17 21:41 UTC (permalink / raw)
To: Len Brown; +Cc: Yu Luming, linux-acpi
Commit e9dab1960ac9746fa34eff726b81635147615a79 exports ACPI
video hotkey events via input layer. But this breaks kernel
build if ACPI_VIDEO && !INPUT:
LD .tmp_vmlinux1
drivers/built-in.o: In function `acpi_video_bus_remove':
drivers/acpi/video.c:2007: undefined reference to `input_unregister_device'
...
Add dependency to INPUT for ACPI_VIDEO to prevent this error.
Signed-off-by: Andreas Herrmann <aherrman@arcor.de>
---
drivers/acpi/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 4875f01..9685b75 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -117,6 +117,7 @@ config ACPI_BUTTON
config ACPI_VIDEO
tristate "Video"
depends on X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL
+ depends on INPUT
help
This driver implement the ACPI Extensions For Display Adapters
for integrated graphics devices on motherboard, as specified in
--
1.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] acpi_video: kernel build error if !INPUT
2007-09-17 21:41 [PATCH] acpi_video: kernel build error if !INPUT Andreas Herrmann
@ 2007-09-18 16:53 ` Len Brown
0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2007-09-18 16:53 UTC (permalink / raw)
To: Andreas Herrmann; +Cc: Yu Luming, linux-acpi
Applied.
thanks,
-Len
On Monday 17 September 2007 17:41, Andreas Herrmann wrote:
> Commit e9dab1960ac9746fa34eff726b81635147615a79 exports ACPI
> video hotkey events via input layer. But this breaks kernel
> build if ACPI_VIDEO && !INPUT:
>
> LD .tmp_vmlinux1
> drivers/built-in.o: In function `acpi_video_bus_remove':
> drivers/acpi/video.c:2007: undefined reference to `input_unregister_device'
> ...
>
> Add dependency to INPUT for ACPI_VIDEO to prevent this error.
>
> Signed-off-by: Andreas Herrmann <aherrman@arcor.de>
> ---
> drivers/acpi/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 4875f01..9685b75 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -117,6 +117,7 @@ config ACPI_BUTTON
> config ACPI_VIDEO
> tristate "Video"
> depends on X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL
> + depends on INPUT
> help
> This driver implement the ACPI Extensions For Display Adapters
> for integrated graphics devices on motherboard, as specified in
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-09-18 16:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-17 21:41 [PATCH] acpi_video: kernel build error if !INPUT Andreas Herrmann
2007-09-18 16:53 ` Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).