[PATCH] Removing of useless printk in drivers/acpi/video.c

[PATCH] Removing of useless printk in drivers/acpi/video.c

[Maik Broemme]

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

Hi,

i am actually heavily using the ACPI video extension for my Thinkpad X61
Tablet. I have bound the input events triggered by the brightness
up/down keys to a simple

echo <value> > /sys/class/backlight/acpi_video1/brightness

but everytime the event is triggered and acpi_video_device_lcd_set_level()
is called i got a notificication in my kernel log like:

set_level status: 0
set_level status: 0
set_level status: 0
set_level status: 0
...

I have attached a patch to remove this one printk() i really don't know
why it is needed. :)

--Maik

[-- Attachment #2: linux-2.6.23-rc6-acpi-video-fix.patch --]
[-- Type: text/plain, Size: 476 bytes --]

diff -Nur linux-2.6.23-rc6-acpi-video-fix/drivers/acpi/video.c linux-2.6.23-rc6/drivers/acpi/video.c
--- linux-2.6.23-rc6-acpi-video-fix/drivers/acpi/video.c	2007-09-11 04:50:29.000000000 +0200
+++ linux-2.6.23-rc6/drivers/acpi/video.c	2007-09-14 22:06:21.000000000 +0200
@@ -417,7 +417,6 @@
 	arg0.integer.value = level;
 	status = acpi_evaluate_object(device->dev->handle, "_BCM", &args, NULL);
 
-	printk(KERN_DEBUG "set_level status: %x\n", status);
 	return status;
 }
 

Re: [PATCH] Removing of useless printk in drivers/acpi/video.c

[Len Brown]

hmmm, thought we had deleted this already.
anyway, its applied.

thanks,
-Len

On Friday 14 September 2007 16:12, Maik Broemme wrote:
> Hi,
> 
> i am actually heavily using the ACPI video extension for my Thinkpad X61
> Tablet. I have bound the input events triggered by the brightness
> up/down keys to a simple
> 
> echo <value> > /sys/class/backlight/acpi_video1/brightness
> 
> but everytime the event is triggered and acpi_video_device_lcd_set_level()
> is called i got a notificication in my kernel log like:
> 
> set_level status: 0
> set_level status: 0
> set_level status: 0
> set_level status: 0
> ...
> 
> I have attached a patch to remove this one printk() i really don't know
> why it is needed. :)
> 
> --Maik
>