From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: 2.6.23-rc6: S4 and S5 no longer listed as supported on Toshiba Satellite A40 Date: Thu, 20 Sep 2007 22:07:12 +0200 Message-ID: <200709202207.13101.rjw@sisk.pl> References: <200709192014.08443.elendil@planet.nl> <200709202017.50934.elendil@planet.nl> <46F2BD0D.2010206@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from ogre.sisk.pl ([217.79.144.158]:39887 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753610AbXITTyO (ORCPT ); Thu, 20 Sep 2007 15:54:14 -0400 In-Reply-To: <46F2BD0D.2010206@gmail.com> Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Alexey Starikovskiy Cc: Frans Pop , Pavel Machek , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Maciek Rutecki On Thursday, 20 September 2007 20:33, Alexey Starikovskiy wrote: > Frans Pop wrote: > > On Thursday 20 September 2007, you wrote: > >> Please try this patch. > > > > Works. All states are now listed again. > > I've not tested suspend to disk, but suspend to ram and power off work fine. > > > >> +printk(KERN_INFO PREFIX "(supports"); > >> #ifdef CONFIG_SUSPEND > >> - printk(KERN_INFO PREFIX "(supports"); > >> for (i = ACPI_STATE_S0; i < ACPI_STATE_S4; i++) { > > > > Isn't there a risk now that we now end up printing > > ACPI: (supports) > > if CONFIG_SUSPEND is not enabled and >S4 is not supported? > > > > Or, more probably, it would print > > ACPI: (supports S5) > Don't know what does it mean to support S0 exactly... :) > > as it is unlikely that "off" is not supported :-) > > > > Maybe S0 should be taken outside the #ifdef and the loop as that state is > > also basically always there? > Don't think it is worth the trouble. We already have this loop almost completely unrolled, > let's not make it complete mess... Well, you could use "(supports S0" instead of just "(supports". ;-) Greetings, Rafael