From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frans Pop Subject: Re: 2.6.23-rc6: S4 and S5 no longer listed as supported on Toshiba Satellite A40 Date: Thu, 20 Sep 2007 23:18:43 +0200 Message-ID: <200709202318.44676.elendil@planet.nl> References: <200709192014.08443.elendil@planet.nl> <200709202207.13101.rjw@sisk.pl> <200709202232.33309.elendil@planet.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from hpsmtp-eml16.kpnxchange.com ([213.75.38.116]:15701 "EHLO hpsmtp-eml16.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751937AbXITVSr (ORCPT ); Thu, 20 Sep 2007 17:18:47 -0400 In-Reply-To: <200709202232.33309.elendil@planet.nl> Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: Alexey Starikovskiy , Pavel Machek , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Maciek Rutecki On Thursday 20 September 2007, Frans Pop wrote: > On Thursday 20 September 2007, Rafael J. Wysocki wrote: > > On Thursday, 20 September 2007 20:33, Alexey Starikovskiy wrote: > > > Frans Pop wrote: > > > > Maybe S0 should be taken outside the #ifdef and the loop as that > > > > state is also basically always there? > > > > > > Don't think it is worth the trouble. We already have this loop almost > > > completely unrolled, let's not make it complete mess... > > > > Well, you could use "(supports S0" instead of just "(supports". ;-) > > After thinking about this a bit more, I think this does make sense for > three (admittedly minor) reasons: > - consistency between messages with and without CONFIG_SUSPEND > - consistency with /proc/acpi/sleep > - avoiding unnecessary change from previous versions. One additional reason... With current code, sleep_states(0) will not be set if compiled without CONFIG_SUSPEND, which means that S0 will also disappear from /proc/acpi/sleep. With pre-2.6.23 code it would be listed there. I think that is even a more relevant change than the display issue and could possibly even be considered a user-space interface regression. My proposed patch fixes that too. Note that the patch currently does not call acpi_get_sleep_type_data for S0, but (partially from Rafael's comment) I was assuming that for S0 that does not really matter. If it does, then the patch could easily be adjusted to include that.