Re: [PATCH 6/7] ACPI: thinkpad-acpi: dequeue all pending hot key events at once

[Len Brown <lenb@kernel.org>]

On Friday 21 September 2007 09:53, Henrique de Moraes Holschuh wrote:
> On Thu, 20 Sep 2007, Len Brown wrote:
> > On Thursday 20 September 2007 09:50, Henrique de Moraes Holschuh wrote:
> > > Receive all pending hot key events at once from a single notification, and
> > > don't complain if the queue is empty.
> 
> Maybe I should have s/hot.?key/HKEY/ throughout this patch.
> 
> The HKEY handler is the thinkpad-specific handler to message-pass
> interesting events to the O.S. This include hot key pressing, but also
> inclures: LID open/close, radio switch toggling, what looks like thermal
> alarms, reason for wakeup (bay eject, whatever), notification of impending
> undock (to show a helper to the user explaining how to undock a x40/x60,
> etc)... and only IBM and Lenovo knows what else.  Hot key presses are just
> one of the many things reported through thinkpad HKEY events.
> 
> > If this is really an event due to an hotkey (emphasis on the word KEY:-),
> > why is it being sent via netlink instead of via input?
> 
> Like I said, if it hit that branch, it is some other notification than a hot
> key press :-)  Yeah, it is non-obvious.
> 
> I will rework the patch to use the word HKEY event instead of hotkey event
> where applicable.

Thanks for the clarification, Henrique.