From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gary Hade Subject: Re: [Pcihpd-discuss] what is writing to /sys/bus/pci/slot//power really supposed to do? Date: Mon, 1 Oct 2007 10:43:41 -0700 Message-ID: <20071001174340.GA10858@us.ibm.com> References: <20071001100858.06919a1e.kristen.c.accardi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from e35.co.us.ibm.com ([32.97.110.153]:42350 "EHLO e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751892AbXJARnz (ORCPT ); Mon, 1 Oct 2007 13:43:55 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e35.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id l91Hhjnp007228 for ; Mon, 1 Oct 2007 13:43:45 -0400 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l91HhiQK429912 for ; Mon, 1 Oct 2007 11:43:44 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l91HhhEn009704 for ; Mon, 1 Oct 2007 11:43:44 -0600 Content-Disposition: inline In-Reply-To: <20071001100858.06919a1e.kristen.c.accardi@intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Kristen Carlson Accardi Cc: pcihpd-discuss@lists.sourceforge.net, linux-acpi@vger.kernel.org, gregkh@suse.de On Mon, Oct 01, 2007 at 10:08:58AM -0700, Kristen Carlson Accardi wrote: > Hi, > I notice in acpiphp that the code path for powering down the slot > via sysfs does not execute the _EJ0 method, but instead simply > looks for _PS3 and of couse disables all the bridges and devices. > I suppose this could be valid depending on your definition of what > /sys/bus/pci/slots//power should do. > > Is it intended to just power down the adapter that's in the slot, > or is it intended to make the adapter in the slot able to be removed? > If it's intended to make the adapter able to be removed, shouldn't > we be calling _EJ0? > > As a comparison, in pciehp when the sysfs power file is written, > we do actually go out and send the commands to the hotplug controller > to physically power off the slot. Kristen, This sounds a lot like the problem I was trying to address with the "fix slot poweroff problem on systems without _PS3" patch that I posted in June. http://sourceforge.net/mailarchive/forum.php?thread_name=20070604232736.GA3239%40us.ibm.com&forum_name=pcihpd-discuss It seems to be working fine on our systems. Gary -- Gary Hade System x Enablement IBM Linux Technology Center 503-578-4503 IBM T/L: 775-4503 garyhade@us.ibm.com http://www.ibm.com/linux/ltc