From: Len Brown <lenb@kernel.org>
To: ACPI List <linux-acpi@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH] ACPI: cpuidle: port idle timer suspend/resume workaround to cpuidle
Date: Thu, 4 Oct 2007 01:22:43 -0400 [thread overview]
Message-ID: <200710040122.43759.lenb@kernel.org> (raw)
From: Len Brown <len.brown@intel.com>
Some timers stop during C2 and C3, and so there are various
generations of timer broadcast workarounds to deal with that.
But that (already complex) code gets confused during suspend.
As it is unlikely that deep C-states would save much power
during the actual suspend/resume process anyway, deep C-states
were disabled via the addition of .suspend/.resume hooks
in to the ACPI processor driver.
Here that workaround is ported to the cpuidle version of
the ACPI idle loop. Technically, ACPI could un-register
itself from cpuidle on .suspend, but that code path
is currently quite cumbersome. So instead,
we simply invoke C1 from the C2 and C3 handlers
for the duration of .suspend/.resume.
Signed-off-by: Len Brown <len.brown@intel.com>
---
processor_idle.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index d924aa3..3b62632 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -1373,6 +1373,10 @@ static int acpi_idle_enter_simple(struct cpuidle_device *dev,
if (unlikely(!pr))
return 0;
+ if (acpi_idle_suspend)
+ return(acpi_idle_enter_c1(dev, state));
+
+
local_irq_disable();
current_thread_info()->status &= ~TS_POLLING;
/*
@@ -1431,6 +1435,9 @@ static int acpi_idle_enter_bm(struct cpuidle_device *dev,
if (unlikely(!pr))
return 0;
+ if (acpi_idle_suspend)
+ return(acpi_idle_enter_c1(dev, state));
+
local_irq_disable();
current_thread_info()->status &= ~TS_POLLING;
/*
next reply other threads:[~2007-10-04 5:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 5:22 Len Brown [this message]
2007-10-08 22:17 ` [PATCH] ACPI: cpuidle: port idle timer suspend/resume workaround to cpuidle Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710040122.43759.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox